(CONT-776) - Correct Style/RedundantRegexpEscape

Author: jordanbreen28

.rubocop_todo.yml

@@ -164,15 +164,6 @@ RSpec/StubbedMock:
   Exclude:
     - 'spec/unit/lib/facter/docker_spec.rb'
 
-# Offense count: 42
-# This cop supports safe autocorrection (--autocorrect).
-Style/RedundantRegexpEscape:
-  Exclude:
-    - 'spec/acceptance/docker_custom_source_spec.rb'
-    - 'spec/acceptance/docker_full_spec.rb'
-    - 'spec/acceptance/docker_spec.rb'
-    - 'spec/classes/compose_spec.rb'
-
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
 Style/RedundantSelfAssignmentBranch:

spec/acceptance/docker_custom_source_spec.rb

@@ -38,7 +38,7 @@
         end
       else
         run_shell('ps aux | grep docker') do |r|
-          expect(r.stdout).to match %r{dockerd -H unix:\/\/\/var\/run\/docker.sock}
+          expect(r.stdout).to match %r{dockerd -H unix:///var/run/docker.sock}
         end
       end
     end

spec/acceptance/docker_full_spec.rb

@@ -88,7 +88,7 @@
             end
           else
             run_shell('ps aux | grep docker') do |r|
-              expect(r.stdout).to match(%r{dockerd -H unix:\/\/\/var\/run\/docker.sock})
+              expect(r.stdout).to match(%r{dockerd -H unix:///var/run/docker.sock})
             end
           end
         end
@@ -194,7 +194,7 @@ class { 'docker':
             end
           else
             run_shell('netstat -tulpn | grep docker') do |r|
-              expect(r.stdout).to match(%r{tcp\s+0\s+0\s+127.0.0.1:4444\s+0.0.0.0\:\*\s+LISTEN\s+\d+\/docker})
+              expect(r.stdout).to match(%r{tcp\s+0\s+0\s+127.0.0.1:4444\s+0.0.0.0:\*\s+LISTEN\s+\d+/docker})
             end
           end
         end
@@ -218,7 +218,7 @@ class { 'docker':
         it 'shows docker listening on the specified unix socket' do
           if os[:family] != 'windows'
             run_shell('ps aux | grep docker') do |r|
-              expect(r.stdout).to match(%r{unix:\/\/\/var\/run\/docker.sock})
+              expect(r.stdout).to match(%r{unix:///var/run/docker.sock})
             end
           end
         end
@@ -505,7 +505,7 @@ class { 'docker': #{docker_args}}
         sleep 4
 
         run_shell("#{docker_command} ps") do |r|
-          expect(r.stdout).to match(%r{#{default_run_command}.+5555\/tcp\, 0\.0\.0.0\:\d+\-\>4444\/tcp})
+          expect(r.stdout).to match(%r{#{default_run_command}.+5555/tcp, 0\.0\.0.0:\d+->4444/tcp})
         end
       end
 
@@ -609,7 +609,7 @@ class { 'docker': #{docker_args} }
         sleep 4
 
         run_shell("#{docker_command} inspect container_3_5_5") do |r|
-          expect(r.stdout).to match(%r{"CpusetCpus"\: "0"})
+          expect(r.stdout).to match(%r{"CpusetCpus": "0"})
         end
       end
 

spec/acceptance/docker_spec.rb

@@ -118,7 +118,7 @@ class { 'docker': #{docker_args} }
       apply_manifest(pp, catch_failures: true)
       run_shell(shell_command) do |r|
         if os[:family] == 'windows'
-          expect(r.stdout).to match(%r{\"data-root\": \"#{root_dir}\"})
+          expect(r.stdout).to match(%r{"data-root": "#{root_dir}"})
         else
           expect(r.stdout).to match(%r{--data-root #{root_dir}})
         end
@@ -195,7 +195,7 @@ class { 'docker':
     it 'netstat -tlndp' do
       result = run_shell('netstat -tlndp')
       expect(result[:exit_code]).to eq 0
-      expect(result[:stdout]).to match %r{0\.0\.0\.0\:80}
+      expect(result[:stdout]).to match %r{0\.0\.0\.0:80}
     end
 
     it 'id testuser | grep docker' do
@@ -235,7 +235,7 @@ class { 'docker':
 
     it 'has a registry mirror set' do
       run_shell('ps -aux | grep docker') do |r|
-        expect(r.stdout).to match(%r{--registry-mirror=http:\/\/testmirror.io})
+        expect(r.stdout).to match(%r{--registry-mirror=http://testmirror.io})
       end
     end
   end
@@ -255,8 +255,8 @@ class { 'docker':
 
     it 'has all registry mirrors set' do
       run_shell('ps -aux | grep docker') do |r|
-        expect(r.stdout).to match(%r{--registry-mirror=http:\/\/testmirror1.io})
-        expect(r.stdout).to match(%r{--registry-mirror=http:\/\/testmirror2.io})
+        expect(r.stdout).to match(%r{--registry-mirror=http://testmirror1.io})
+        expect(r.stdout).to match(%r{--registry-mirror=http://testmirror2.io})
       end
     end
   end

spec/classes/compose_spec.rb

@@ -74,7 +74,7 @@
           end
 
           if params['proxy'] != :undef
-            unless %r{^((https?)?:\/\/)?([^:^@]+:[^:^@]+@|)([\da-z\.-]+)\.([\da-z\.]{2,6})(:\d)?([\/\w \.-]*)*\/?$}.match?(params['proxy'])
+            unless %r{^((https?)?://)?([^:^@]+:[^:^@]+@|)([\da-z.-]+)\.([\da-z.]{2,6})(:\d)?([/\w .-]*)*/?$}.match?(params['proxy'])
               it {
                 expect(subject).to compile.and_raise_error(%r{does not match})
               }