(GH-819) Introduce tmpdir property

This commit introduces a new tmpdir property for the docker_compose
resource that allows the module consumer to decide on the value of
TMPDIR (The location that docker compose uses for temp files).

With the new implementation:

If the tmpdir property is not set, the docker compose will use it's
default value of /tmp.

If the tmpdir property is set, the docker
compose will use the value of the tmpdir property.

It is the responsibility of the consumer to ensure that the directory
passed to the tmpdir is available and writable by the user that is
running puppet.

Author: chelnak

Diff for: lib/puppet/provider/docker_compose/ruby.rb

@@ -14,8 +14,7 @@
   end
 
   has_command(:docker_compose, command(:dockercompose)) do
-    Dir.mkdir('/tmp_docker') unless Dir.exist?('/tmp_docker')
-    ENV.store('TMPDIR', '/tmp_docker')
+    environment(HOME: '/root')
   end
 
   def exists?
@@ -76,33 +75,40 @@ def get_image(service_name, compose_services)
   def create
     Puppet.info("Running compose project #{name}")
     args = [compose_files, '-p', name, 'up', '-d', '--remove-orphans'].insert(3, resource[:options]).insert(5, resource[:up_args]).compact
-    dockercompose(args)
+    exec_dockercompose(args)
     return unless resource[:scale]
     instructions = resource[:scale].map { |k, v| "#{k}=#{v}" }
     Puppet.info("Scaling compose project #{name}: #{instructions.join(' ')}")
     args = [compose_files, '-p', name, 'scale'].insert(3, resource[:options]).compact + instructions
-    dockercompose(args)
+    exec_dockercompose(args)
   end
 
   def destroy
     Puppet.info("Removing all containers for compose project #{name}")
     kill_args = [compose_files, '-p', name, 'kill'].insert(3, resource[:options]).compact
-    dockercompose(kill_args)
+    exec_dockercompose(kill_args)
     rm_args = [compose_files, '-p', name, 'rm', '--force', '-v'].insert(3, resource[:options]).compact
-    dockercompose(rm_args)
+    exec_dockercompose(rm_args)
   end
 
   def restart
     return unless exists?
     Puppet.info("Rebuilding and Restarting all containers for compose project #{name}")
     kill_args = [compose_files, '-p', name, 'kill'].insert(3, resource[:options]).compact
-    dockercompose(kill_args)
+    exec_dockercompose(kill_args)
     build_args = [compose_files, '-p', name, 'build'].insert(3, resource[:options]).compact
-    dockercompose(build_args)
+    exec_dockercompose(build_args)
     create
   end
 
   def compose_files
     resource[:compose_files].map { |x| ['-f', x] }.flatten
   end
+
+  def exec_dockercompose(args)
+    ENV.store('TMPDIR', resource[:tmpdir]) unless tmpdir.nil? 
+    dockercompose(args)
+  end
+
+  private :exec_dockercompose
 end

Diff for: lib/puppet/type/docker_compose.rb

@@ -47,4 +47,19 @@ def refresh
     isnamevar
     desc 'The name of the project'
   end
+
+  newproperty(:tmpdir) do
+    desc "Override the temporary directory used by docker-compose.
+
+    This property is useful when the /tmp directory has been mounted
+    with the noexec option. Or is otherwise being prevented  It allows the module consumer to redirect
+    docker-composes temporary files to a known directory.
+
+    The directory passed to this property must exist and be accessible
+    by the user that is executing the puppet agent.
+    "
+    validate do |value|
+      raise _('tmpdir should be a String') unless value.is_a? String
+    end
+  end
 end