update docker_stack to fix registry auth option (#364)

* update docker_stack to fix registry auth option

* single quotes for rubocop

* updating registry auth param to boolean

* ensuring the registry auth option uses boolean

Author: davejrt

lib/puppet/parser/functions/docker_stack_flags.rb

@@ -26,8 +26,8 @@ module Puppet::Parser::Functions
       flags << "--prune '#{opts['prune']}'"
     end
 
-    if opts['with_registry_auth'].to_s != 'undef'
-      flags << "--with-registry-auth '#{opts['with_registry_auth']}'"
+    if opts['with_registry_auth']
+      flags << '--with-registry-auth'
     end
 
     flags.flatten.join(' ')

manifests/stack.pp

@@ -41,7 +41,7 @@
   Optional[String] $bundle_file                                  = undef,
   Optional[Array] $compose_files                                 = undef,
   Optional[String] $prune                                        = undef,
-  Optional[String] $with_registry_auth                           = undef,
+  Optional[Boolean] $with_registry_auth                          = false,
   Optional[Pattern[/^always$|^changed$|^never$/]] $resolve_image = undef,
   ){