Use versioncmp instead of type casting (#330)

PierreR · davejrt · commit 48fa6720444d · 2018-09-26T16:47:58.000+10:00
* Remove one unnecessary type annotation

* Add versioncmp to compare version (instead of casting)
diff --git a/manifests/init.pp b/manifests/init.pp
@@ -494,7 +494,7 @@
     }
   }
 
-  if ($::operatingsystem == 'CentOS') and (Integer($::operatingsystemmajrelease) < 7){
+  if ($::operatingsystem == 'CentOS') and (versioncmp($::operatingsystemmajrelease, '7') < 0) {
     fail(translate('This module only works on CentOS version 7 and higher based systems.'))
   }
 

Original file line number	Diff line number	Diff line change
`@@ -494,7 +494,7 @@`
`494`	`494`	`}`
`495`	`495`	`}`
`496`	`496`
`497`		`- if ($::operatingsystem == 'CentOS') and (Integer($::operatingsystemmajrelease) < 7){`
	`497`	`+ if ($::operatingsystem == 'CentOS') and (versioncmp($::operatingsystemmajrelease, '7') < 0) {`
`498`	`498`	`fail(translate('This module only works on CentOS version 7 and higher based systems.'))`
`499`	`499`	`}`
`500`	`500`