Merge pull request #468 from electrofelix/noop-latest-images

Allow images tagged latest to update on each run

Author: carabasdaniel

manifests/image.pp

@@ -140,7 +140,21 @@
       timeout     => $exec_timeout,
       logoutput   => true,
     }
-  } elsif $ensure == 'latest' or $image_tag == 'latest' or $ensure == 'present' {
+  } elsif $ensure == 'latest' or $image_tag == 'latest' {
+    notify { "Check if image ${image_arg} is in-sync":
+      noop      => false,
+    }
+    ~> exec { "echo 'Update of ${image_arg} complete'":
+      environment => $exec_environment,
+      path        => $exec_path,
+      timeout     => $exec_timeout,
+      onlyif      => $image_install,
+      require     => File[$update_docker_image_path],
+      provider    => $exec_provider,
+      logoutput   => true,
+      refreshonly => true,
+    }
+  } elsif $ensure == 'present' {
     exec { $image_install:
       unless      => $_image_find,
       environment => $exec_environment,

spec/defines/image_spec.rb

@@ -134,17 +134,17 @@
 
   context 'with ensure => latest' do
     let(:params) { { 'ensure' => 'latest' } }
-    it { should contain_exec("/usr/local/bin/update_docker_image.sh base") }
+    it { should contain_exec("echo 'Update of base complete'").with_onlyif('/usr/local/bin/update_docker_image.sh base') }
   end
 
   context 'with ensure => latest and image_tag => precise' do
     let(:params) { { 'ensure' => 'latest', 'image_tag' => 'precise' } }
-    it { should contain_exec("/usr/local/bin/update_docker_image.sh base:precise") }
+    it { should contain_exec("echo 'Update of base:precise complete'") }
   end
 
   context 'with ensure => latest and image_digest => sha256:deadbeef' do
     let(:params) { { 'ensure' => 'latest', 'image_digest' => 'sha256:deadbeef' } }
-    it { should contain_exec("/usr/local/bin/update_docker_image.sh base@sha256:deadbeef") }
+    it { should contain_exec("echo 'Update of base@sha256:deadbeef complete'") }
   end
 
   context 'with an invalid image name' do

spec/defines/image_windows_spec.rb

@@ -48,7 +48,7 @@
 
     context 'with ensure => latest' do
         let(:params) { { 'ensure' => 'latest' } }
-        it { should contain_exec("& C:/Users/Administrator/AppData/Local/Temp/update_docker_image.ps1 -DockerImage base") }
+        it { should contain_exec("echo 'Update of base complete'").with_onlyif('& C:/Users/Administrator/AppData/Local/Temp/update_docker_image.ps1 -DockerImage base') }
     end
 
 end