Skip to content

Commit 840963d

Browse files
author
Mark Wilson
committed
merge in Daves fixes
2 parents 39e70c9 + 2097f1e commit 840963d

File tree

2 files changed

+19
-19
lines changed

2 files changed

+19
-19
lines changed

Diff for: lib/puppet/provider/docker_compose/ruby.rb

+15-18
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
commands docker: 'docker'
77

88
def exists?
9-
Puppet.info("Checking for compose project #{project}")
9+
Puppet.info("Checking for compose project #{name}")
1010
compose_services = {}
1111
resource[:compose_files].each do |file|
1212
compose_file = YAML.safe_load(File.read(file))
@@ -15,7 +15,7 @@ def exists?
1515
'--format',
1616
"{{.Label \"com.docker.compose.service\"}}-{{.Image}}",
1717
'--filter',
18-
"label=com.docker.compose.project=#{project}",
18+
"label=com.docker.compose.project=#{name}",
1919
]).split("\n")
2020
case compose_file['version']
2121
when %r{^2(\.[0-3])?$}, %r{^3(\.[0-6])?$}
@@ -63,40 +63,37 @@ def get_image(service_name, compose_services)
6363
end
6464

6565
def create
66-
Puppet.info("Running compose project #{project}")
67-
compose_files_cmd = resource[:compose_files].map { |x| ["-f", x] }.flatten
68-
args = [compose_files_cmd, 'up', '-d', '--remove-orphans'].insert(2, resource[:options]).insert(5, resource[:up_args]).compact
66+
Puppet.info("Running compose project #{name}")
67+
args = [compose_files, '-p', name, 'up', '-d', '--remove-orphans'].insert(2, resource[:options]).insert(5, resource[:up_args]).compact
6968
dockercompose(args)
7069
return unless resource[:scale]
7170
instructions = resource[:scale].map { |k, v| "#{k}=#{v}" }
7271
Puppet.info("Scaling compose project #{project}: #{instructions.join(' ')}")
73-
args = [compose_files_cmd, 'scale'].insert(2, resource[:options]).compact + instructions
72+
args = [compose_files, '-p', name, 'scale'].insert(2, resource[:options]).compact + instructions
7473
dockercompose(args)
7574
end
7675

7776
def destroy
78-
Puppet.info("Removing all containers for compose project #{project}")
79-
compose_files_cmd = resource[:compose_files].map { |x| ["-f", x] }.flatten
80-
kill_args = [compose_files_cmd, 'kill'].insert(2, resource[:options]).compact
77+
Puppet.info("Removing all containers for compose project #{name}")
78+
kill_args = [compose_files, '-p', name, 'kill'].insert(2, resource[:options]).compact
8179
dockercompose(kill_args)
82-
rm_args = [compose_files_cmd, 'rm', '--force', '-v'].insert(2, resource[:options]).compact
80+
rm_args = [compose_files, '-p', name, 'rm', '--force', '-v'].insert(2, resource[:options]).compact
8381
dockercompose(rm_args)
8482
end
8583

8684
def restart
8785
return unless exists?
88-
Puppet.info("Rebuilding and Restarting all containers for compose project #{project}")
89-
kill_args = ['-f', name, 'kill'].insert(2, resource[:options]).compact
86+
Puppet.info("Rebuilding and Restarting all containers for compose project #{name}")
87+
kill_args = [compose_files, '-p', name, 'kill'].insert(2, resource[:options]).compact
9088
dockercompose(kill_args)
91-
build_args = ['-f', name, 'build'].insert(2, resource[:options]).compact
89+
build_args = [compose_files, '-p', name, 'build'].insert(2, resource[:options]).compact
9290
dockercompose(build_args)
9391
create
9492
end
9593

96-
private
97-
98-
def project
99-
project = name
100-
project
94+
def compose_files
95+
resource[:compose_files].map { |x| ['-f', x] }.flatten
10196
end
97+
98+
private
10299
end

Diff for: lib/puppet/provider/docker_network/ruby.rb

+4-1
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,9 @@ def self.instances
3838
_, name, driver = line.split(' ')
3939
inspect = docker(['network', 'inspect', name])
4040
obj = JSON.parse(inspect).first
41+
ipam_driver = unless obj['IPAM']['Driver'].empty?
42+
obj['IPAM']['Driver']
43+
end
4144
subnet = unless obj['IPAM']['Config'].empty?
4245
if obj['IPAM']['Config'].first.key? 'Subnet'
4346
obj['IPAM']['Config'].first['Subnet']
@@ -46,7 +49,7 @@ def self.instances
4649
new(
4750
:name => name,
4851
:id => obj['Id'],
49-
:ipam_driver => obj['IPAM']['Driver'],
52+
:ipam_driver => ipam_driver,
5053
:subnet => subnet,
5154
:ensure => :present,
5255
:driver => driver,

0 commit comments

Comments
 (0)