Skip to content

Commit 9cac9f5

Browse files
committed
Additional changes to account for incompatible image
1 parent 70c1421 commit 9cac9f5

File tree

3 files changed

+34
-4
lines changed

3 files changed

+34
-4
lines changed

spec/acceptance/compose_v3_spec.rb

+5-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,11 @@
55
file_extension = '.exe'
66
docker_args = 'docker_ee => true'
77
tmp_path = 'C:/cygwin64/tmp'
8-
test_container = 'nanoserver-sac2016'
8+
if fact('os.release.major') == '2019'
9+
test_container = 'nanoserver'
10+
else
11+
test_container = 'nanoserver-sac2016'
12+
end
913
else
1014
docker_args = if fact('os.name') == 'RedHat'
1115
"repo_opt => '--enablerepo=localmirror-extras'"

spec/acceptance/docker_full_spec.rb

+5-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,11 @@
33
if fact('kernel') == 'windows'
44
docker_args = 'docker_ee => true'
55
default_image = 'winamd64/hello-seattle'
6-
default_image_tag = 'nanoserver-sac2016'
6+
if fact('os.release.major') == '2019'
7+
default_image_tag = 'nanoserver'
8+
else
9+
default_image_tag = 'nanoserver-sac2016'
10+
end
711
default_digest = 'sha256:dcba85354678b50608b8c40ec6d17cce063a224aa0e12b6a55dc47b67f039e75'
812
second_image = 'winamd64/hola-mundo'
913
default_dockerfile = 'C:/Users/Administrator/AppData/Local/Temp/Dockerfile'

spec/spec_helper_acceptance.rb

+24-2
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,17 @@ def retry_on_error_matching(max_retry_count = 3, retry_wait_interval_secs = 5, e
135135
EOS
136136
docker_compose_override_v3_windows = <<-EOS
137137
version: "3"
138+
services:
139+
compose_test:
140+
image: winamd64/hello-seattle:nanoserver
141+
command: cmd.exe /C "ping 8.8.8.8 -t"
142+
networks:
143+
default:
144+
external:
145+
name: nat
146+
EOS
147+
docker_compose_override_v3_windows_2016 = <<-EOS
148+
version: "3"
138149
services:
139150
compose_test:
140151
image: winamd64/hello-seattle:nanoserver-sac2016
@@ -153,15 +164,26 @@ def retry_on_error_matching(max_retry_count = 3, retry_wait_interval_secs = 5, e
153164
EOS
154165
docker_stack_override_windows = <<-EOS
155166
version: "3"
167+
services:
168+
compose_test:
169+
image: winamd64/hello-seattle:nanoserver
170+
EOS
171+
docker_stack_override_windows_2016 = <<-EOS
172+
version: "3"
156173
services:
157174
compose_test:
158175
image: winamd64/hello-seattle:nanoserver-sac2016
159176
EOS
160177
if fact_on(host, 'osfamily') == 'windows'
161178
create_remote_file(host, '/tmp/docker-compose-v3.yml', docker_compose_content_v3_windows)
162179
create_remote_file(host, '/tmp/docker-stack.yml', docker_stack_content_windows)
163-
create_remote_file(host, '/tmp/docker-compose-override-v3.yml', docker_compose_override_v3_windows)
164-
create_remote_file(host, '/tmp/docker-stack-override.yml', docker_stack_override_windows)
180+
if fact_on(host, 'os.release.major') == '2019'
181+
create_remote_file(host, '/tmp/docker-compose-override-v3.yml', docker_stack_override_windows)
182+
create_remote_file(host, '/tmp/docker-stack-override.yml', docker_stack_override_windows)
183+
else
184+
create_remote_file(host, '/tmp/docker-compose-override-v3.yml', docker_stack_override_windows_2016)
185+
create_remote_file(host, '/tmp/docker-stack-override.yml', docker_stack_override_windows_2016)
186+
end
165187
else
166188
create_remote_file(host, '/tmp/docker-compose-v3.yml', docker_compose_content_v3)
167189
create_remote_file(host, '/tmp/docker-stack.yml', docker_compose_content_v3)

0 commit comments

Comments
 (0)