(CONT-776) - Correct Style/TernaryParentheses

Author: jordanbreen28

.rubocop_todo.yml

@@ -156,17 +156,6 @@ RSpec/StubbedMock:
   Exclude:
     - 'spec/unit/lib/facter/docker_spec.rb'
 
-# Offense count: 4
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, AllowSafeAssignment.
-# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
-Style/TernaryParentheses:
-  Exclude:
-    - 'lib/puppet/provider/docker_compose/ruby.rb'
-    - 'lib/puppet/provider/docker_stack/ruby.rb'
-    - 'spec/shared_examples/run.rb'
-    - 'spec/shared_examples/services.rb'
-
 # Offense count: 190
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyleForMultiline.

lib/puppet/provider/docker_compose/ruby.rb

@@ -45,7 +45,7 @@ def exists?
     return false if compose_services.count != compose_containers.uniq.count
 
     counts = Hash[*compose_services.each.map { |key, array|
-                    image = (array['image']) ? array['image'] : get_image(key, compose_services)
+                    image = array['image'] || get_image(key, compose_services)
                     Puppet.info("Checking for compose service #{key} #{image}")
                     [key, compose_containers.count("'#{key}-#{image}'")]
                   }.flatten]

lib/puppet/provider/docker_stack/ruby.rb

@@ -39,7 +39,7 @@ def exists?
     return false if stack_services.count != stack_containers.count
 
     counts = Hash[*stack_services.each.map { |key, array|
-                    image = (array['image']) ? array['image'] : get_image(key, stack_services)
+                    image = array['image'] || get_image(key, stack_services)
                     image = "#{image}:latest" unless image.include?(':')
                     Puppet.info("Checking for compose service #{key} #{image}")
                     ["#{key}-#{image}", stack_containers.count("#{key}-#{image}")]

spec/shared_examples/run.rb

@@ -451,7 +451,7 @@
         'ports' => ports,
         'stop_wait_time' => stop_wait_time,
         'container_running' => running,
-        'logfile_path' => facts[:os]['family'] == 'windows' ? facts['docker_user_temp_path'] : '/tmp',
+        'logfile_path' => (facts[:os]['family'] == 'windows') ? facts['docker_user_temp_path'] : '/tmp',
       }
 
       detect_changes = get_docker_params_changed(docker_params_changed_args)

spec/shared_examples/services.rb

@@ -57,7 +57,7 @@
     )
 
     exec_create   = "#{docker_command} create --name #{docker_service_create_flags}"
-    unless_create = "docker service ps #{service_name == :undef ? '' : service_name}"
+    unless_create = "docker service ps #{(service_name == :undef) ? '' : service_name}"
 
     it {
       expect(subject).to contain_exec("#{title} docker service create").with(