Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AmazonLinux 2 #747

Closed
PolaricEntropy opened this issue May 1, 2021 · 4 comments
Closed

Add support for AmazonLinux 2 #747

PolaricEntropy opened this issue May 1, 2021 · 4 comments

Comments

@PolaricEntropy
Copy link
Contributor

Use Case

I'm using AmazonLinux 2 on Puppet nodes I want to use this module. That used to work before PR 667.

Describe the Solution You Would Like

If os.family is RedHat, but name is Amazon then skip the version requirement.

Describe Alternatives You've Considered

The current solution is to use 3.12.1, which makes us miss out on improvements.

Additional Context

AmazonLinux 2 is REHL 7 and thus has the os.family fact set to RedHat. Since the release version numbers describe the OS version it's in our AMI set to 2.2 which triggers a version check error.

@djtecha
Copy link

djtecha commented Jun 15, 2021

Any update on this? Appears that everything else works for us using docker_compose we just have to comment out that fail condition. Tried overriding using the acknowledge_unsupported_os = true to also bypass it but gets caught on line #488 in the init.pp file

@adrianiurca
Copy link
Contributor

Currently we are not supporting Amazon Linux 2, but we could try to add compatibility for AmazonLinux 2.

@PolaricEntropy
Copy link
Contributor Author

Made #788 to make the acknowledge_unsupported_os setting allow Amazon Linux 2. Allows us to use the module there even though it's not officially supported yet.

@github-actions
Copy link

This issue has been marked as stale because it has been open for a while and has had no recent activity. If this issue is still important to you please drop a comment below and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants