-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using Packages from Debian Repository fails with missing docker-ce-cli package #797
Comments
I'd guess we need to remove https://github.com/puppetlabs/puppetlabs-docker/blob/main/manifests/install.pp#L83-L86 and the test for that. |
Hi @kenyon, just upgraded to 4.1.2 and commented the mentioned code section. Works fine without errors. Regards |
In puppetlabs#740 I mistakenly added code that manages the docker-ce-cli package when managing the "docker" package. The docker-ce-cli package should only be managed when also managing the docker-ce package. Fixes puppetlabs#797
Same problem exists on RHEL as well, manifests tries to install package even if docker-ce is not used |
I think this PR should fix it. |
In puppetlabs#740 I mistakenly added code that manages the docker-ce-cli package when managing the "docker" package. The docker-ce-cli package should only be managed when also managing the docker-ce package. Fixes puppetlabs#797
When using the Debian repo (use_upstream_pacakge_source => false) the module is trying to install docker-ce-cli, which is not available in the Debian repositories. There is just 'docker.io'.
This only happens when using puppetlabs-docker > 4.0.1
I know Debian 11 is officially not on the supported OS list... and I'd like to use the packages from the official Debian repository.
Expected Behavior
With puppetlabs-docker 4.0.1 everything works as expected. I think this issue was introduced with #740.
Steps to Reproduce
Steps to reproduce the behavior:
is there a way to get around this issue and using the latest module version ?
Or am I doing something wrong ?
Thanks and regards
Peter
Environment
The text was updated successfully, but these errors were encountered: