Fix "password" as Property

Having "password" defined with newparam, any Content of Type Sensitive will lead to
"Unable to mark 'password' as sensitive: password is a parameter and not a property, and cannot be automatically redacted."

In Fact "password" (as well as others) should be a Property.
(compare https://puppet.com/docs/puppet/7/custom_types.html#tandp_properties_and_parameters)

Author: Cocker Koch

Diff for: lib/puppet/type/java_ks.rb

@@ -100,7 +100,7 @@ def insync?(is)
       from a file separate from the server certificate. This will autorequire the specified file.'
   end
 
-  newparam(:password) do
+  newproperty(:password) do
     desc 'The password used to protect the keystore.  If private keys are
       subsequently also protected this password will be used to attempt
       unlocking. Must be six or more characters in length. Cannot be used

Diff for: pdk.yaml

@@ -0,0 +1,2 @@
+---
+ignore: []

Diff for: spec/unit/puppet/type/java_ks_spec.rb

@@ -38,13 +38,13 @@
   end
 
   describe 'when validating attributes' do
-    [:name, :target, :private_key, :private_key_type, :certificate, :password, :password_file, :trustcacerts, :destkeypass, :password_fail_reset, :source_password].each do |param|
+    [:name, :target, :private_key, :private_key_type, :certificate, :password_file, :trustcacerts, :destkeypass, :password_fail_reset, :source_password].each do |param|
       it "has a #{param} parameter" do
         expect(described_class.attrtype(param)).to eq(:param)
       end
     end
 
-    [:ensure].each do |prop|
+    [:ensure, :password].each do |prop|
       it "has a #{prop} property" do
         expect(described_class.attrtype(prop)).to eq(:property)
       end