(maint) spec default for root_home fact

Author: h0tw1r3

.sync.yml

@@ -20,3 +20,7 @@ Rakefile:
   extra_disabled_lint_checks:
     - anchor_resource
     - params_empty_string_assignment
+
+spec/default_facts.yml:
+  extra_facts:
+    root_home: /root

spec/classes/mycnf_template_spec.rb

@@ -5,9 +5,7 @@
 describe 'mysql::server' do
   on_supported_os.each do |os, facts|
     context "my.cnf template - on #{os}" do
-      let(:facts) do
-        facts.merge(root_home: '/root')
-      end
+      let(:facts) { facts }
 
       context 'normal entry' do
         let(:params) { { override_options: { 'mysqld' => { 'socket' => '/var/lib/mysql/mysql.sock' } } } }

spec/classes/mysql_backup_mysqldump_spec.rb

@@ -5,14 +5,12 @@
 describe 'mysql::backup::mysqldump' do
   on_supported_os.each do |os, facts|
     context "on #{os}" do
+      let(:facts) { facts }
       let(:pre_condition) do
         <<-MANIFEST
           class { 'mysql::server': }
         MANIFEST
       end
-      let(:facts) do
-        facts.merge(root_home: '/root')
-      end
 
       let(:default_params) do
         { 'backupuser' => 'testuser',

spec/classes/mysql_backup_xtrabackup_spec.rb

@@ -11,8 +11,7 @@ class { 'mysql::server': }
         MANIFEST
       end
       let(:facts) do
-        facts.merge(root_home: '/root',
-                    mysql_version: '5.7',
+        facts.merge(mysql_version: '5.7',
                     mysld_version: 'mysqld  Ver 5.7.38 for Linux on x86_64 (MySQL Community Server - (GPL)')
       end
 

spec/classes/mysql_bindings_spec.rb

@@ -7,10 +7,7 @@
     next if facts[:os]['family'] == 'Archlinux'
 
     context "on #{os}" do
-      let(:facts) do
-        facts.merge(root_home: '/root')
-      end
-
+      let(:facts) { facts }
       let(:params) do
         {
           'java_enable' => true,

spec/classes/mysql_client_spec.rb

@@ -5,9 +5,7 @@
 describe 'mysql::client' do
   on_supported_os.each do |os, facts|
     context "on #{os}" do
-      let(:facts) do
-        facts.merge(root_home: '/root')
-      end
+      let(:facts) { facts }
 
       context 'with defaults' do
         it { is_expected.to contain_class('mysql::params') }

spec/classes/mysql_server_account_security_spec.rb

@@ -16,7 +16,6 @@
         let(:facts) do
           override_facts(
             super(),
-            'root_home' => '/root',
             'networking' => {
               'fqdn' => 'myhost.mydomain',
               'hostname' => 'myhost',
@@ -55,7 +54,6 @@
         let(:facts) do
           override_facts(
             super(),
-            'root_home' => '/root',
             'networking' => {
               'fqdn' => 'localhost',
               'hostname' => 'localhost',
@@ -79,7 +77,6 @@
         let(:facts) do
           override_facts(
             super(),
-            'root_home' => '/root',
             'networking' => {
               'fqdn' => 'localhost.localdomain',
               'hostname' => 'localhost',

spec/classes/mysql_server_backup_spec.rb

@@ -10,9 +10,7 @@
           class { 'mysql::server': }
         MANIFEST
       end
-      let(:facts) do
-        facts.merge(root_home: '/root')
-      end
+      let(:facts) { facts }
 
       let(:default_params) do
         { 'backupuser' => 'testuser',

spec/classes/mysql_server_spec.rb

@@ -5,9 +5,7 @@
 describe 'mysql::server' do
   on_supported_os.each do |os, facts|
     context "on #{os}" do
-      let(:facts) do
-        facts.merge(root_home: '/root')
-      end
+      let(:facts) { facts }
 
       context 'with defaults' do
         it { is_expected.to contain_class('mysql::params') }

spec/default_facts.yml

@@ -7,3 +7,5 @@ networking:
   ip6: "FE80:0000:0000:0000:AAAA:AAAA:AAAA"
   mac: "AA:AA:AA:AA:AA:AA"
 is_pe: false
+root_home: "/root"
+

spec/defines/mysql_db_spec.rb

@@ -5,10 +5,7 @@
 describe 'mysql::db', type: :define do
   on_supported_os.each do |os, facts|
     context "on #{os}" do
-      let(:facts) do
-        facts.merge(root_home: '/root')
-      end
-
+      let(:facts) { facts }
       let(:title) { 'test_db' }
 
       let(:params) do