Fix frozen string errors

Author: DavidS

lib/puppet/provider/mysql.rb

@@ -145,7 +145,7 @@ def self.cmd_table(table)
     table_string = ''
 
     # We can't escape *.* so special case this.
-    table_string << if table == '*.*'
+    table_string += if table == '*.*'
                       '*.*'
                     # Special case also for FUNCTIONs and PROCEDUREs
                     elsif table.start_with?('FUNCTION ', 'PROCEDURE ')
@@ -160,7 +160,7 @@ def self.cmd_privs(privileges)
     return 'ALL PRIVILEGES' if privileges.include?('ALL')
     priv_string = ''
     privileges.each do |priv|
-      priv_string << "#{priv}, "
+      priv_string += "#{priv}, "
     end
     # Remove trailing , from the last element.
     priv_string.sub(%r{, $}, '')
@@ -170,7 +170,7 @@ def self.cmd_privs(privileges)
   def self.cmd_options(options)
     option_string = ''
     options.each do |opt|
-      option_string << ' WITH GRANT OPTION' if opt == 'GRANT'
+      option_string += ' WITH GRANT OPTION' if opt == 'GRANT'
     end
     option_string
   end

lib/puppet/provider/mysql_grant/mysql.rb

@@ -81,9 +81,9 @@ def grant(user, table, privileges, options)
     priv_string = self.class.cmd_privs(privileges)
     table_string = privileges.include?('PROXY') ? self.class.cmd_user(table) : self.class.cmd_table(table)
     query = "GRANT #{priv_string}"
-    query << " ON #{table_string}"
-    query << " TO #{user_string}"
-    query << self.class.cmd_options(options) unless options.nil?
+    query += " ON #{table_string}"
+    query += " TO #{user_string}"
+    query += self.class.cmd_options(options) unless options.nil?
     self.class.mysql_caller(query, 'system')
   end
 

lib/puppet/provider/mysql_login_path/inifile.rb

@@ -461,11 +461,11 @@ def parse_value(string)
       if leading_quote?
         # check for a closing quote at the end of the string
         if string =~ @close_quote
-          value << Regexp.last_match(1)
+          self.value += Regexp.last_match(1)
 
           # otherwise just append the string to the value
         else
-          value << string
+          self.value += string
           continuation = true
         end
 
@@ -480,19 +480,27 @@ def parse_value(string)
           continuation = true
 
         when @trailing_slash
-          value ? value << Regexp.last_match(1) : self.value = Regexp.last_match(1)
+          if self.value
+            self.value += Regexp.last_match(1)
+          else
+            self.value = Regexp.last_match(1)
+          end
           continuation = true
 
         when @normal_value
-          value ? value << Regexp.last_match(1) : self.value = Regexp.last_match(1)
+          if self.value
+            self.value += Regexp.last_match(1)
+          else
+            self.value = Regexp.last_match(1)
+          end
 
         else
           error
         end
       end
 
       if continuation
-        value << $INPUT_RECORD_SEPARATOR if leading_quote?
+        self.value += $INPUT_RECORD_SEPARATOR if leading_quote?
       else
         process_property
       end

lib/puppet/provider/mysql_user/mysql.rb

@@ -159,8 +159,8 @@ def password_hash=(string)
       else
         concat_name = @resource[:name]
         sql = "UPDATE mysql.user SET password = '', plugin = 'ed25519'"
-        sql << ", authentication_string = '#{string}'"
-        sql << " where CONCAT(user, '@', host) = '#{concat_name}'; FLUSH PRIVILEGES"
+        sql += ", authentication_string = '#{string}'"
+        sql += " where CONCAT(user, '@', host) = '#{concat_name}'; FLUSH PRIVILEGES"
       end
       self.class.mysql_caller(sql, 'system')
     elsif newer_than('mysql' => '5.7.6', 'percona' => '5.7.6', 'mariadb' => '10.2.0')
@@ -210,17 +210,17 @@ def plugin=(string)
       else
         concat_name = @resource[:name]
         sql = "UPDATE mysql.user SET password = '', plugin = '#{string}'"
-        sql << ", authentication_string = '#{@resource[:password_hash]}'"
-        sql << " where CONCAT(user, '@', host) = '#{concat_name}'; FLUSH PRIVILEGES"
+        sql += ", authentication_string = '#{@resource[:password_hash]}'"
+        sql += " where CONCAT(user, '@', host) = '#{concat_name}'; FLUSH PRIVILEGES"
       end
     elsif newer_than('mysql' => '5.7.6', 'percona' => '5.7.6', 'mariadb' => '10.2.0')
       sql = "ALTER USER #{merged_name} IDENTIFIED WITH '#{string}'"
-      sql << " AS '#{@resource[:password_hash]}'" if string == 'mysql_native_password'
+      sql += " AS '#{@resource[:password_hash]}'" if string == 'mysql_native_password'
     else
       # See https://bugs.mysql.com/bug.php?id=67449
       sql = "UPDATE mysql.user SET plugin = '#{string}'"
-      sql << ((string == 'mysql_native_password') ? ", password = '#{@resource[:password_hash]}'" : ", password = ''")
-      sql << " WHERE CONCAT(user, '@', host) = '#{@resource[:name]}'"
+      sql += ((string == 'mysql_native_password') ? ", password = '#{@resource[:password_hash]}'" : ", password = ''")
+      sql += " WHERE CONCAT(user, '@', host) = '#{@resource[:name]}'"
     end
 
     self.class.mysql_caller(sql, 'system')