(FM-4563) skip idempotency tests on test cells that do have PUP-5016 unfixed

Arguably this decision should be extracted to a more central place,
like puppetlabs_spec_helper or the CI config.

Author: DavidS

spec/spec_helper_acceptance.rb

@@ -12,6 +12,12 @@
   # Readable test descriptions
   c.formatter = :documentation
 
+  # detect the situation where PUP-5016 is triggered and skip the idempotency tests in that case
+  # also note how fact('puppetversion') is not available because of PUP-4359
+  if fact('osfamily') == 'Debian' && fact('operatingsystemmajrelease') == '8' && shell('puppet --version').stdout =~ /^4\.2/
+    c.filter_run_excluding :skip_pup_5016 => true
+  end
+
   # Configure all nodes in nodeset
   c.before :suite do
     # Install module and dependencies
@@ -53,7 +59,7 @@
     apply_manifest(pp, :catch_failures => true)
   end
 
-  it 'should apply a second time without changes' do
+  it 'should apply a second time without changes', :skip_pup_5016 do
     apply_manifest(pp, :catch_changes => true)
   end
 end