Merge pull request #37 from tkishel/scripts_cleanup

(maint) shellcheck, spacing, and case

Author: Thomas Kishel

files/puppet_enterprise_database_backup.sh

@@ -1,7 +1,7 @@
 #!/bin/bash
 
 usage() {
-  echo "usage: $0  [-t BACKUP_TARGET] [-l LOG_DIRECTORY] [-r retention] <DATABASE> [DATABASE_N ...]"
+  echo "usage: $0 [-t TARGET_BACKUP_DIRECTORY] [-l LOG_DIRECTORY] [-r RETENTION] <DATABASE> [DATABASE_N ...]"
   exit 1
 }
 

files/vacuum_full_tables.sh

@@ -2,9 +2,9 @@
 
 usage() {
   cat <<EOF
-echo "usage: $0 <table set> [sleep duration]"
-where <table set> is one of: facts catalogs other
-and [sleep duration] is an optional integer of seconds to sleep.  Defaults to 300
+echo "usage: $0 <TABLE_SET> [SLEEP_DURATION]"
+where <TABLE_SET> is one of: facts catalogs other
+and [SLEEP_DURATION] is an optional integer of seconds to sleep. Defaults to 300
 EOF
   exit 1
 }
@@ -27,14 +27,14 @@ case "$1" in
     usage
 esac
 
-
 SQL="SELECT t.relname::varchar AS table_name
   FROM pg_class t
   JOIN pg_namespace n
     ON n.oid = t.relnamespace
   WHERE t.relkind = 'r'
     AND t.relname IN ( $(IFS=,; echo "${vacuum_tables[*]}") )"
 
+# shellcheck disable=SC2207
 tables=($(su - pe-postgres -s /bin/bash -c "/opt/puppetlabs/server/bin/psql -d pe-puppetdb -c \"$SQL\" --tuples-only"))
 
 for table in "${tables[@]}"; do