Fix rubocop

Author: ody

Diff for: spec/plans/add_replica_spec.rb

@@ -11,17 +11,21 @@ def allow_standard_non_returning_calls
 
   describe 'basic functionality' do
     let(:params) { { 'primary_host' => 'primary', 'replica_host' => 'replica' } }
-    let(:certdata) { {
-      'certificate-exists' => true,
-      'certname'           => 'primary',
-      'extensions'         => { '1.3.6.1.4.1.34380.1.1.9813' => 'A' },
-      'dns-alt-names'      => []
-    } }
-    let(:certstatus) { {
-      'certificate-status' => 'valid',
-      'reason'             => 'Expires - 2099-01-01 00:00:00 UTC'
-    } }
     let(:cfg) { { 'params' => { 'primary_host' => 'primary' } } }
+    let(:certdata) do
+      {
+        'certificate-exists' => true,
+        'certname'           => 'primary',
+        'extensions'         => { '1.3.6.1.4.1.34380.1.1.9813' => 'A' },
+        'dns-alt-names'      => []
+      }
+    end
+    let(:certstatus) do
+      {
+        'certificate-status' => 'valid',
+        'reason'             => 'Expires - 2099-01-01 00:00:00 UTC'
+      }
+    end
 
     it 'runs successfully when the primary does not have alt-names' do
       allow_standard_non_returning_calls

Diff for: tasks/cert_valid_status.rb

@@ -4,7 +4,7 @@
 require 'puppet'
 require 'json'
 
-$params = JSON.parse(STDIN.read)
+params = JSON.parse(STDIN.read)
 
 Puppet.initialize_settings
 
@@ -14,7 +14,7 @@
   cert_provider = Puppet::X509::CertProvider.new
   ssl_provider = Puppet::SSL::SSLProvider.new
   password = cert_provider.load_private_key_password
-  ssl_context = ssl_provider.load_context(certname: $params['certname'], password: password)
+  ssl_context = ssl_provider.load_context(certname: params['certname'], password: password)
 rescue Puppet::SSL::CertVerifyError => e
   status = { 'certificate-status' => 'invalid', 'reason' => e.message }
 rescue Puppet::Error => e
@@ -27,4 +27,4 @@
 result = status
 
 # Put the result to stdout
-puts result.to_json
+puts result.to_json