(PE-38802) Adding note about PE Infra agent group purge (#509)

Also added additional legacy compiler updates to classification docs

Author: ragingra

documentation/classification.md

@@ -4,6 +4,8 @@
 
 This reference implementation uses four non-default node classification groups to implement the Extra Large DR architecture. Intentionally, classification of default, out-of-box node groups is not modified. This allows normal commands such as `puppet infrastructure enable replica` to behave more or less exactly as they would in Standard or Large architecture clusters.
 
+>Please note, as of PEADM 3.21 the node group **PE Infrastructure Agent** now has it's assosiated rules enforced. This means that custom rules added to the group will be purged during actions such as `peadm::convert` and `peadm::upgrade`.  
+
 This image shows a fully expanded view of the PE Infrastructure node group, highlighting the new additions made to support the Extra Large architecture.
 
 ![PE Classification tree](images/pe-xl-classification.png)
@@ -16,6 +18,9 @@ The new groups are:
 * PE Primary B
 * PE Compiler Group A
 * PE Compiler Group B
+* PE Legacy Compiler
+* PE Legacy Compiler Group A
+* PE Legacy Compiler Group B
 
 The configuration applied in each group looks as follows:
 
@@ -73,3 +78,33 @@ Notes for PE Compiler Group B:
     * If you have a load balancer for the compilers in PE Compiler Group A port 8081, you should use that load balancer address instead of "primary-a"
 * Modifies the `puppet_enterprise::profile::master::puppetdb_port` parameter
     * Should be set to `[8081]`
+
+### PE Legacy Compiler
+
+Notes on PE Legacy Compiler:
+
+* Introduced in PEADM 3.25 along with the legacy compiler functionality
+* Similar to the native PE Compiler group, and used to contain legacy compilers
+* For more info on legacy compilers, please see [here](upgrade_with_legacy_compilers.md)
+
+### PE Legacy Compiler Group A
+
+Notes on PE Legacy Compiler Group A:
+
+* Modifies the `puppet_enterprise::profile::master::puppetdb_host` parameter
+    * Should be set to `[${clientcert}, "primary-b"]`, where "primary-b" is the name of the (initial) Primary Replica.
+    * If you have a load balancer for the compilers in PE Legacy Compiler Group B port 8081, you should use that load balancer address instead of "primary-b"
+* Modifies the `puppet_enterprise::profile::master::puppetdb_port` parameter
+    * Should be set to `[8081]`
+
+### PE Legacy Compiler Group B
+
+Notes on PE Legacy Compiler Group B:
+
+* Modifies the `puppet_enterprise::profile::master::puppetdb_host` parameter
+    * Should be set to `[${clientcert}, "primary-a"]`, where "primary-a" is the name of the PuppetDB PostgreSQL node paired with the (initial) Primary Replica.
+    * If you have a load balancer for the compilers in PE Legacy Compiler Group A port 8081, you should use that load balancer address instead of "primary-a"
+* Modifies the `puppet_enterprise::profile::master::puppetdb_port` parameter
+    * Should be set to `[8081]`
+
+

documentation/convert.md

@@ -2,6 +2,8 @@
 
 The peadm::convert plan can be used to adopt manually deployed infrastructure for use with PEADM or to adopt infrastructure deployed with an older version of peadm.
 
+>To understand what classifications PEADM adds to your infrastructure, please see [here](classification.md).
+
 ## Convert an Existing Deployment
 
 Prepare to run the plan against all servers in the PE infrastructure, using a params.json file such as this one:

documentation/upgrade.md

@@ -8,6 +8,8 @@ The `peadm::upgrade` plan requires as input the version of PE to upgrade to, and
 
 Please note that when upgrading from before 2023.4 to 2023.4 or above and you are using code manager, it is nessesary to provide known hosts for r10k. r10k_known_hosts is an optional parameter and is only required one time when upgrading to 2023.4 or beyond. But if you currently use the SSH protocol to allow r10k to access your remote Git repository, your Code manager or r10k code management tool cannot function until you define the r10k_known_hosts parameter. Subsequent upgrades will already have this and it won't be required again. Please refer to the Puppet Enterprise 2023.4 Upgrade cautions for more details.
 
+>To understand what classifications PEADM adds to your infrastructure, please see [here](classification.md).
+
 The following is an example parameters file for upgrading an Extra Large architecture deployment of PE 2023.2.0 to PE 2023.8.0.
 
 ```json