Try to ensure LANG is valid

If Ruby starts without a LANG env var, it will assume locale "C". This
is a non-UTF-8 locale, and usually not the system default. If commands
print UTF-8 characters, Ruby will fail to correctly parse them if it
wasn't started with a valid locale.

The main scenario we want to account for is when a privilege escalation
command such as sudo or powerbroker has elevated a shell, but stripped
all environment variables out of it. If that happened, we want to try
and set the default system locale, which should be in
/etc/default/locale.

Author: reidmv

tasks/agent_upgrade.sh

@@ -1,5 +1,8 @@
 #!/bin/bash
 
+# Try and ensure locale is correctly configured
+[ -z "${LANG}" ] && export LANG=$(localectl status | sed -n 's/.* LANG=\(.*\)/\1/p')
+
 export USER=$(id -un)
 export HOME=$(getent passwd "$USER" | cut -d : -f 6)
 export PATH="/opt/puppetlabs/bin:${PATH}"

tasks/enable_replica.sh

@@ -1,5 +1,8 @@
 #!/bin/bash
 
+# Try and ensure locale is correctly configured
+[ -z "${LANG}" ] && export LANG=$(localectl status | sed -n 's/.* LANG=\(.*\)/\1/p')
+
 USER=$(id -un)
 HOME=$(getent passwd "$USER" | cut -d : -f 6)
 

tasks/pe_install.sh

@@ -1,5 +1,8 @@
 #!/bin/bash
 
+# Try and ensure locale is correctly configured
+[ -z "${LANG}" ] && export LANG=$(localectl status | sed -n 's/.* LANG=\(.*\)/\1/p')
+
 # This stanza configures PuppetDB to quickly fail on start. This is desirable
 # in situations where PuppetDB WILL fail, such as when PostgreSQL is not yet
 # configured, and we don't want to let PuppetDB wait five minutes before
@@ -20,10 +23,6 @@ pedir=$(tar -tf "$PT_tarball" | head -n 1 | xargs dirname)
 
 tar -C "$tgzdir" -xzf "$PT_tarball"
 
-export LANG=en_US.UTF-8
-export LANGUAGE=en_US.UTF-8
-export LC_ALL=en_US.UTF-8
-
 if [ ! -z "$PT_peconf" ]; then
 	/bin/bash "${tgzdir}/${pedir}/puppet-enterprise-installer" -y -c "$PT_peconf"
 else

tasks/provision_replica.sh

@@ -1,5 +1,8 @@
 #!/bin/bash
 
+# Try and ensure locale is correctly configured
+[ -z "${LANG}" ] && export LANG=$(localectl status | sed -n 's/.* LANG=\(.*\)/\1/p')
+
 export USER=$(id -un)
 export HOME=$(getent passwd "$USER" | cut -d : -f 6)
 export PATH="/opt/puppetlabs/bin:${PATH}"

tasks/puppet_runonce.sh

@@ -1,5 +1,9 @@
 #!/bin/bash
 
+# Try and ensure locale is correctly configured
+[ -z "${LANG}" ] && export LANG=$(localectl status | sed -n 's/.* LANG=\(.*\)/\1/p')
+
+# Parse noop parameter
 [ "$PT_noop" = "true" ] && NOOP_FLAG="--noop" || unset NOOP_FLAG
 
 # Wait for up to five minutes for an in-progress Puppet agent run to complete