remove manual systemd drop-in file handling

  * add puppet/systemd module
  * remove systemd daemon reload and raise minimal puppet version to 6.1
  * remove old "drop-in file" removal, was in place 3 years now
  * move systemd drop-in file handling to seperate define
  * Implement recent feedback
  * define is now private
  * rename parameter in define call
  * fix unit tests
  * fix rubocop complains
  * fix path, set default fact
  * fix systemd drop in file, adding template parameters to systemd define
  * added reason for drop in file in a comment

Author: SimonHoenscheid

manifests/params.pp

@@ -18,6 +18,7 @@
   $service_manage               = true
   $service_restart_on_change    = true
   $service_provider             = $postgresql::globals::service_provider
+  $systemd_drop_in_ensure       = 'present'
   $manage_pg_hba_conf           = pick($manage_pg_hba_conf, true)
   $manage_pg_ident_conf         = pick($manage_pg_ident_conf, true)
   $manage_recovery_conf         = pick($manage_recovery_conf, false)

manifests/server.pp

@@ -15,6 +15,7 @@
 # @param service_provider Overrides the default PostgreSQL service provider.
 # @param service_reload Overrides the default reload command for your PostgreSQL service.
 # @param service_status Overrides the default status check command for your PostgreSQL service.
+# @param systemd_drop_in_ensure sets the Systemd drop-in file to present or absent
 # @param default_database Specifies the name of the default database to connect with. On most systems this is 'postgres'.
 # @param default_connect_settings Specifies a hash of environment variables used when connecting to a remote server. Becomes the default for other defined types, such as postgresql::server::role.
 #
@@ -103,6 +104,7 @@
   $service_provider                                = $postgresql::params::service_provider,
   $service_reload                                  = $postgresql::params::service_reload,
   $service_status                                  = $postgresql::params::service_status,
+  Enum[present, absent] $systemd_drop_in_ensure    = $postgresql::params::systemd_drop_in_ensure,
   $default_database                                = $postgresql::params::default_database,
   $default_connect_settings                        = $postgresql::globals::default_connect_settings,
   $listen_addresses                                = $postgresql::params::listen_addresses,

manifests/server/instance/config.pp

@@ -29,6 +29,7 @@
 # @param logdir PostgreSQL log directory
 # @param service_name Overrides the default PostgreSQL service name.
 # @param service_enable Enable the PostgreSQL service
+# @param systemd_drop_in_ensure sets the Systemd drop-in file to present or absent
 # @param log_line_prefix PostgreSQL log line prefix
 # @param timezone Set timezone for the PostgreSQL instance
 # @param extra_systemd_config Adds extra config to systemd config file, can for instance be used to add extra openfiles. This can be a multi line string
@@ -57,6 +58,7 @@
   $logdir                                          = $postgresql::server::logdir,
   $service_name                                    = $postgresql::server::service_name,
   $service_enable                                  = $postgresql::server::service_enable,
+  Enum[present, absent] $systemd_drop_in_ensure    = $postgresql::server::systemd_drop_in_ensure,
   $log_line_prefix                                 = $postgresql::server::log_line_prefix,
   $timezone                                        = $postgresql::server::timezone,
   $password_encryption                             = $postgresql::server::password_encryption,