REMIND fix this

Author: joshcooper

manifests/osfamily/redhat.pp

@@ -164,6 +164,7 @@
         true    => '_none_',
         default => $puppet_agent::proxy,
       }
+
       yumrepo { 'pc_repo':
         baseurl             => $source,
         descr               => "Puppet Labs ${puppet_agent::collection} Repository",
@@ -178,6 +179,10 @@
         username            => $puppet_agent::username,
         password            => $puppet_agent::password,
       }
+      file { '/etc/yum.repos.d/pc_repo.repo':
+        ensure => file,
+        mode   => "0600"
+      }
     }
   }
 }

manifests/osfamily/suse.pp

@@ -134,10 +134,13 @@
             # 'auto' versus X.Y.Z
             $_package_version = getvar('puppet_agent::master_or_package_version')
 
+            # REMIND: why is this is_pe??
             # REMIND: add credentials to PuppetcoreCreds
             $pw = unwrap($puppet_agent::password)
             $url = URI($source)
-            $baseurl = "${url.scheme}://${puppet_agent::username}:${pw}@${url.host}/${url.path}?auth=basic&ssl_verify=no"
+            # REMIND: should this be sensitive? so it doesn't show in yum repo diff?
+            # REMIND: what about ssl_verify=no?
+            $baseurl = Sensitive("${url.scheme}://${puppet_agent::username}:${pw}@${url.host}/${url.path}?auth=basic&ssl_verify=no")
 
             # In Puppet Enterprise, agent packages are served by the same server
             # as the master, which can be using either a self signed CA, or an external CA.