Upgrade puppetcore* msi from artifacts-puppetcore.puppet.com

When using the puppetcore collection on Windows, if we detect the installed
version does not match, then upgrade the MSI. Due to a puppet bug, we cannot
pass credentials in the `source` parameter. And `curl.exe` is not present in
our puppet-agent packages. So use powershell to download.

Co-authored-by: Kevin <[email protected]>

Author: 2 people

REFERENCE.md

@@ -619,6 +619,35 @@ The puppet-agent version to install.
 
 Default value: `undef`
 
+### <a name="puppet_agent--prepare--package"></a>`puppet_agent::prepare::package`
+
+for installation. This is used on platforms without package managers capable of
+working with a remote https repository.
+
+#### Parameters
+
+The following parameters are available in the `puppet_agent::prepare::package` class:
+
+* [`source`](#-puppet_agent--prepare--package--source)
+* [`package_file_name`](#-puppet_agent--prepare--package--package_file_name)
+
+##### <a name="-puppet_agent--prepare--package--source"></a>`source`
+
+Data type: `Variant[String, Array]`
+
+The source file for the puppet-agent package. Can use any of the data types
+and protocols that the File resource's source attribute can.
+
+##### <a name="-puppet_agent--prepare--package--package_file_name"></a>`package_file_name`
+
+Data type: `Optional[String]`
+
+The destination file name for the puppet-agent package. If no destination
+is given, then the basename component of the source will be used as the
+destination filename.
+
+Default value: `undef`
+
 ### <a name="puppet_agent--prepare--puppet_config"></a>`puppet_agent::prepare::puppet_config`
 
 Private class called from puppet_agent::prepare class.

manifests/osfamily/windows.pp

@@ -2,6 +2,8 @@
 class puppet_agent::osfamily::windows {
   assert_private()
 
+  $destination_name = undef
+
   if $puppet_agent::absolute_source {
     $source = $puppet_agent::absolute_source
   } elsif $puppet_agent::source {