Merge pull request #61 from jarretlavallee/fix/master/pretty

Reduce the size of files on disk

Author: Sharpie

files/metrics_tidy

@@ -32,7 +32,7 @@ done
 
 
 # Guard against deleting or archiving files outside of a Puppet service metrics directory.
-valid_paths=(puppetserver puppetdb orchestrator ace bolt activemq)
+valid_paths=(puppetserver puppetdb orchestrator ace bolt activemq system_processes system_memory system_cpu)
 
 # Arguments and defaults.
 metrics_directory="${metrics_directory:-/opt/puppetlabs/puppet-metrics-collector/puppetserver}"
@@ -52,6 +52,13 @@ paths_regex="$(IFS='|'; echo "${valid_paths[*]}")"
 find "$metrics_directory" -type f -ctime +"$retention_days" -delete
 
 # Compress the remaining files in a Puppet service metrics directory.
-# The return code of a pipeline is the rightmost command, which means we trigger our trap if tar fails
-find "$metrics_directory" -type f -name "*json" | \
-  tar --create --gzip --file "${metrics_directory}/${metrics_type}-$(date +%Y.%m.%d.%H.%M.%S).tar.gz" --files-from -
+# Store the list of files in a temp file so that `tar` and `rm` will operate on the same files
+metrics_tmp="$(mktemp)"
+find "$metrics_directory" -type f -name "*json" >"$metrics_tmp"
+tar --create --gzip --file "${metrics_directory}/${metrics_type}-$(date +%Y.%m.%d.%H.%M.%S).tar.gz" \
+  --files-from "$metrics_tmp"
+
+# Cleanup the backed up json files so that we do not duplicate files in the tarballs.
+# We can assume that the json files have no spaces as they are created by our scripts
+xargs -a "$metrics_tmp" rm
+rm "$metrics_tmp"

files/system_metrics

@@ -325,7 +325,7 @@ module SystemMetrics
       hostkey = @hostname.gsub('.', '-')
       metrics_json = {'timestamp' => @time_stamp_obj.utc.iso8601, 'servers' => {}}
       metrics_json['servers'][hostkey] = {@metric_type => metrics_data}
-      JSON.pretty_generate(metrics_json)
+      JSON.generate(metrics_json)
     end
 
     # Create the metric file and put the json data in it