Skip to content

Commit 2a45aed

Browse files
committed
Remove tests for "active" metrics services
Prior to this commit, the acceptance tests were testing for either an active or inactive state for the services. We don't need to do this for oneshot services triggered by a timer, since we only care about the state of the timer. For PE metrics, we do have a test that explicitly runs the service to check that the output directory is being populated, so that case is already accounted for.
1 parent 75bbc80 commit 2a45aed

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

spec/acceptance/pe_system_spec.rb

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,6 @@
4646
expect(apply_manifest(pp).exit_code).not_to eq(1)
4747
end
4848

49-
it 'system puppet_* metric services should be active or inactive' do
50-
run_shell('systemctl list-units --type=service | grep "puppet_system.*metrics"') do |r|
51-
expect(r.stdout).to match(%r{activ})
52-
end
53-
end
54-
5549
context 'system timers are running' do
5650
it { expect(service('puppet_system_cpu-metrics.timer')).to be_running }
5751
it { expect(service('puppet_system_cpu-tidy.timer')).to be_running }
@@ -82,12 +76,6 @@ class { 'puppet_metrics_collector::system':
8276
expect(package('sysstat')).to be_installed
8377
end
8478

85-
it 'system puppet_* metric services should be active or inactive' do
86-
run_shell('systemctl list-units --type=service | grep "puppet_system.*metrics"') do |r|
87-
expect(r.stdout).to match(%r{activ})
88-
end
89-
end
90-
9179
context 'system timers are running' do
9280
it { expect(service('puppet_system_cpu-metrics.timer')).to be_running }
9381
it { expect(service('puppet_system_cpu-tidy.timer')).to be_running }

0 commit comments

Comments
 (0)