Merge pull request #412 from puppetlabs/bug-remove_manfiest_dir

(bug) - remove obselete manfiest dir config setting & require rspec-puppet 4.x

Author: gavindidrichsen

lib/puppetlabs_spec_helper/module_spec_helper.rb

@@ -67,7 +67,6 @@ def verify_contents(subject, title, expected_lines)
 
   c.environmentpath = spec_path
   c.module_path = module_path
-  c.manifest_dir = File.join(fixture_path, 'manifests')
 
   # https://github.com/puppetlabs/rspec-puppet#strict_variables
   c.strict_variables = ENV['STRICT_VARIABLES'] != 'no'

puppetlabs_spec_helper.gemspec

@@ -33,7 +33,7 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'puppet-lint', '~> 4.0'
   spec.add_runtime_dependency 'puppet-syntax', '~> 3.0'
   spec.add_runtime_dependency 'rspec-github', '~> 2.0'
-  spec.add_runtime_dependency 'rspec-puppet', '>= 2.0'
+  spec.add_runtime_dependency 'rspec-puppet', '~> 4.0'
 
   spec.requirements << 'puppet, >= 7.0.0'
 end