Merge pull request #435 from puppetlabs/gh-397-honour_default_symlink

(bug) - check for empty fixtures array, as well as nil

Author: LukasAud

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2024-02-01 17:06:08 UTC using RuboCop version 1.50.2.
+# on 2024-02-09 08:47:26 UTC using RuboCop version 1.50.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -17,7 +17,7 @@ Gemspec/RequireMFA:
 # Offense count: 5
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
-  Max: 58
+  Max: 60
 
 # Offense count: 3
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns, inherit_mode.
@@ -28,7 +28,7 @@ Metrics/BlockLength:
 # Offense count: 4
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
-  Max: 18
+  Max: 19
 
 # Offense count: 11
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
@@ -49,7 +49,7 @@ Metrics/ParameterLists:
 # Offense count: 3
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/PerceivedComplexity:
-  Max: 21
+  Max: 22
 
 # Offense count: 1
 # Configuration parameters: IgnoredMetadata.

lib/puppetlabs_spec_helper/tasks/fixtures.rb

@@ -106,8 +106,7 @@ def fixtures(category)
                            end
 
         fixtures = fixtures['fixtures']
-
-        fixtures['symlinks'] = fixtures['symlinks'].nil? ? auto_symlink : auto_symlink.merge!(fixtures['symlinks'])
+        fixtures['symlinks'] = fixtures['symlinks'].nil? || fixtures['symlinks'].empty? ? auto_symlink : auto_symlink.merge!(fixtures['symlinks'])
 
         result = {}
         if fixtures.include?(category) && !fixtures[category].nil?