Breaking changes; Semigroup, union #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking changes but better
Breaking changes but better
|
I did some measurements. It looks like it performs well. But the sort is surprisingly slow. I peaked some at the sort implementation, and it just looks like nonsense to me, but I'm no Erlang-god. https://github.com/erlang/otp/blob/master/lib/stdlib/src/lists.erl#L507 Collected using: N = 1000000,
X = lists:seq(0,N),
F = fun() -> lists:sort(X) end,
Q = [Y||{_,Y} <- lists:sort([ {rand:uniform(), N} || N <- X])],
G = fun() -> lists:sort(Q) end,
TCN2 = fun(T,F,0) -> ok; (T,F,N) -> F(), T(T,F,N-1) end,
TCN = fun(F,N) -> B=now(), TCN2(TCN2,F,N), A=now(), timer:now_diff(A,B)/N end.
N.
"Sorted:".
TCN(F, 100).
"Unsorted:".
TCN(G, 100). |
There are a few calling indirections, but I don't expect much
performance loss from this. Erlang usually handles functions pretty
well!
We went from this incorrect code:
```
foldMImpl(Bind, F, MZ, M) ->
lists:foldl(fun (K, V, Acc) ->
(Bind(Acc))(fun (Z) -> ((F(Z))(K))(V) end)
end, MZ, lists:sort(maps:keys(M))).
```
To this:
```
foldM() -> fun (DictMonad) ->
Bind@382 = (?MEMOIZE((control_bind@ps:bind(((maps:get('Bind1', DictMonad))(undefined)))))),
Pure@383 = (?MEMOIZE((control_applicative@ps:pure(((maps:get('Applicative0', DictMonad))(undefined)))))),
fun (F) ->
fun (Z) ->
fun (M) ->
(foldl(fun (Acc) ->
fun (K) ->
fun (V) ->
((Bind@382(Acc))(fun (A) ->
(((F(A))(K))(V))
end))
end
end
end, (Pure@383(Z)), M))
end
end
end
end.
```
Optimize Eq instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes:
Based on #10