Skip to content

Commit bfb942e

Browse files
committed
Drop typelevel-prelude dependency
We aren't actually using anything provided by typelevel-prelude; instead, we're only using its re-exports. Dropping the dependency and importing RLProxy and the Union class from where they are defined means that we have fewer dependencies to worry about, so version incompatibilities are less likely to occur. I'd suggest releasing this as a patch-level change; previously we have recommended releasing changes in which dependencies have been dropped as major-level, because it can break downstream libraries if they are relying on the presence of that dependency, but I have come to believe that this policy is worse since it results in far too many unnecessary major version bumps, and downstream libraries depending on a particular transitive dependency but not declaring that dependency are arguably broken anyway.
1 parent 05f0cf2 commit bfb942e

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

bower.json

-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
"purescript-functions": "^4.0.0",
1515
"purescript-nullable": "^4.1.0",
1616
"purescript-record": "^1.0.0",
17-
"purescript-typelevel-prelude": "^3.0.0",
1817
"purescript-unsafe-coerce": "^4.0.0",
1918
"purescript-web-dom": "^1.0.0",
2019
"purescript-web-html": "^1.0.0",

src/React/Basic.purs

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ import Data.Function.Uncurried (Fn2, mkFn2, runFn2)
2828
import Data.Nullable (Nullable, notNull, null)
2929
import Effect (Effect)
3030
import Effect.Uncurried (EffectFn3, runEffectFn3)
31-
import Type.Row (class Union)
31+
import Prim.Row (class Union)
3232

3333
-- | `ComponentSpec` represents a React-Basic component implementation.
3434
-- |

src/React/Basic/Events.purs

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import Effect.Uncurried (EffectFn1, mkEffectFn1)
1919
import Prim.Row as Row
2020
import Prim.RowList (kind RowList, class RowToList, Cons, Nil)
2121
import Record (delete, get, insert)
22-
import Type.Row (RLProxy(..))
22+
import Type.Data.RowList (RLProxy(..))
2323

2424
-- | An event handler, which receives a `SyntheticEvent` and performs some
2525
-- | effects in return.

0 commit comments

Comments
 (0)