Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: toReactComponent doesn't exist (anymore) #129

Closed
andys8 opened this issue Jul 25, 2020 · 4 comments
Closed

Docs: toReactComponent doesn't exist (anymore) #129

andys8 opened this issue Jul 25, 2020 · 4 comments

Comments

@andys8
Copy link
Member

andys8 commented Jul 25, 2020

There is a reference to toReactComponent. It doesn't exist anymore. Not sure by what it was replaced ;)

https://github.com/lumihq/purescript-react-basic/blob/3569fea76dcd776baceda071a6f6286befb92142/src/React/Basic.purs#L70

@maddie927
Copy link
Member

maddie927 commented Jul 25, 2020

It's over here now: https://github.com/lumihq/purescript-react-basic-classic/blob/main/src/React/Basic/Classic.purs#L280

The implementation was split out so you can leave it out if you're using hooks or make a new one. Also makes it easier it update implementations without requiring version bumps across the whole react-basic ecosystem.

@andys8
Copy link
Member Author

andys8 commented Jul 25, 2020

Ah, thank you very much.

I was looking at react-basic-hooks where ReactComponent is re-exported.:

https://pursuit.purescript.org/packages/purescript-react-basic-hooks/6.1.0/docs/React.Basic.Hooks#t:ReactComponent

What I actually needed/wanted is reactComponent and it took me some time to figure out, I had run the effect to be able to import and use it JavaScript land :)

So, I'm looking forward to docs. The library is looking pretty neat :)

@andys8
Copy link
Member Author

andys8 commented Jul 25, 2020

I guess the docs are fine then 😌

@andys8 andys8 closed this as completed Jul 25, 2020
@maddie927
Copy link
Member

Ahh, yes, that could probably be clearer. Planning to have some JS React component interop examples in the shared documentation soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants