Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People skill search bugfixes #798

Open
2 tasks
RandomTannenbaum opened this issue Feb 14, 2025 · 0 comments
Open
2 tasks

People skill search bugfixes #798

RandomTannenbaum opened this issue Feb 14, 2025 · 0 comments
Labels
bug Something isn't working plan needs to be planned

Comments

@RandomTannenbaum
Copy link
Collaborator

Currently the people-skill search has several bugs:

  • When adding the first new row and the default row has no value selected, the dropdown in the default row is automatically set to the first value of the dropdown.
  • When selecting the same skill twice no results are found.
  • The turboframes we utilize (one for the search filters and one for the results) dont seem to work, since updating the slider for the skill level triggers a page refresh.
  • Only relevant if the upgrade to Rails 8 is already merged: The update from Rails 7.1 to 7.2 introduced flaky specs. The fill_out_row method in the spec people_skill_search sometimes fails to update the slider in firefox.
  • The styling is a bit off. The newly added rows are not aligned with the default row:

Image

ToDo

  • Fix bugs that are described above
  • Do a thorough smoke tests and if you find new bugs also fix them
@Robin481 Robin481 added bug Something isn't working plan needs to be planned labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plan needs to be planned
Projects
None yet
Development

No branches or pull requests

2 participants