Skip to content

Commit 23b97c2

Browse files
wholmgrencwhanse
authored andcommitted
Add GTI DIRINT model (#400)
* implement gtidirint without iteration * add option to skip aoi > 90 * make gti dirint gte 90 function private * add some gti_dirint tests * implement vectorized iterative solution. fix gt 90 error * use azimuth in gt 90 function * fix some issues near 90 deg * remove unnecessary comment * add kt option to disc, dirint to fix gte 90 dni issue * update whatsnew, add to api.rst * move to 0.5.2 whatsnew * add gti_dirint tutorial * move changes to 0.6.0 whatsnew * update parameters * fix 0.5.2 whatsnew * rework max_iterations logic * flake8 * update tutorial * api change in whatsnew * clean up whatsnew * update to new api. fix parameters * update notebook [skip ci] * refactor * more refactoring * refactor disc and dirint * clean up * update tutorial * add stubs. use zeros. more clean up * review comments * rerun on master * some broken tests * update parameters, whatsnew. [skip ci] * update tests * update documentation * ignore .vscode * limit clearness index in disc dirint dirindex * fix bad change * update tutorial * remove tutorial * maybe fix failing py27 test * doc clean up * update doi
1 parent 845a75a commit 23b97c2

File tree

5 files changed

+942
-90
lines changed

5 files changed

+942
-90
lines changed

.gitignore

+3-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ pvlib/spa_c_files/spa.h
3838
pvlib/spa_c_files/spa_tester.c
3939

4040
# generated documentation
41-
# pvlib/sphinx/Docs/build/
41+
docs/sphinx/source/generated
42+
docs/sphinx/source/savefig
4243

4344
# Installer logs
4445
pip-log.txt
@@ -62,6 +63,7 @@ coverage.xml
6263
.idea/
6364
*.sublime-project
6465
*.sublime-workspace
66+
.vscode
6567

6668
# Rope
6769
.ropeproject

docs/sphinx/source/api.rst

+10
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,16 @@ DNI estimation models
167167
irradiance.dirindex
168168
irradiance.erbs
169169
irradiance.liujordan
170+
irradiance.gti_dirint
171+
172+
Clearness index models
173+
----------------------
174+
175+
.. autosummary::
176+
:toctree: generated/
177+
178+
irradiance.clearness_index
179+
irradiance.clearness_index_zenith_independent
170180

171181

172182
PV Modeling

docs/sphinx/source/whatsnew/v0.6.0.rst

+6
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@ API Changes
4949
enhancement factor can yield unphysical results, especially for latitudes
5050
closer to the poles and especially in the winter months. It may yield
5151
improved results under other conditions. (:issue:`435`)
52+
* Add min_cos_zenith, max_zenith keyword arguments to disc, dirint, and
53+
dirindex functions. (:issue:`311`, :issue:`396`)
5254

5355

5456
Enhancements
@@ -96,6 +98,9 @@ Enhancements
9698
* Improve performance of Location.get_airmass. Most noticeable when
9799
solar position is supplied, time index length is less than 10000, and
98100
method is looped over. (:issue:`502`)
101+
* Add irradiance.gti_dirint function. (:issue:`396`)
102+
* Add irradiance.clearness_index function. (:issue:`396`)
103+
* Add irradiance.clearness_index_zenith_independent function. (:issue:`396`)
99104

100105

101106
Bug fixes
@@ -118,6 +123,7 @@ Bug fixes
118123
Hay-Davies diffuse sky algorithms. (:issue:`432`)
119124
* Fix argument order of longitude and latitude when querying weather forecasts
120125
by lonlat bounding box (:issue:`521`)
126+
* Fix issue with unbounded clearness index calculation in disc. (:issue:`540`)
121127
* Limit pvwatts_ac results to be greater than or equal to 0. (:issue:`541`)
122128

123129

0 commit comments

Comments
 (0)