Skip to content

Add clearsky index function to pvlib.irradiance #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevinsa5 opened this issue Aug 31, 2018 · 4 comments
Closed

Add clearsky index function to pvlib.irradiance #551

kevinsa5 opened this issue Aug 31, 2018 · 4 comments

Comments

@kevinsa5
Copy link
Contributor

The clearness index kt (the ratio of surface-level GHI to ET irradiance) can be calculated via pvlib.irradiance.clearness_index and is used in the DIRINT and DISC models. Though other metrics in the same vein are not necessary for the irradiance models implemented in pvlib, including them in pvlib could be a convenience to users. Is there interest in implementing other irradiance metrics for users to access? Some examples:

@cwhanse
Copy link
Member

cwhanse commented Aug 31, 2018

I think clearsky_index is needed. Would we pass the clear-sky GHI as an argument, or the name of a clear-sky model? We'd have to agree how to deal with low irradiance conditions, e.g., an upper bound on clearsky_index.

I think the variability calculations are interesting and would be worth adding as functions to the library.

@kevinsa5
Copy link
Contributor Author

Considering clearsky_index as a convenience function, it seems appropriate for it to accept an optional clear-sky model name rather than clear-sky GHI data -- if the user already has both measured and modeled data, then there's not much left to do besides the division anyways. The way that clearness_index handles low-light conditions seems appropriate here as well.

If there is no available bandwidth from the core team for this, I am happy to work up some PRs. Though I cannot promise they would be ready any time soon... free time is always in short supply.

@wholmgren
Copy link
Member

I am all for including these functions. Usually the best approach is to implement very simple functions that implement the core algorithm, then add convenience functions/methods around them. So, for clearsky index, I'd want a function that doesn't do any more than the division and limits (much like clearness_index). That API would be straightforward and can be integrated into many modeling workflows. Consider something like Location.clearsky_index if you want the convenience of computing clear sky data within the function/method call.

Please do submit PRs!

@wholmgren wholmgren added this to the Someday milestone Aug 31, 2018
@kevinsa5 kevinsa5 changed the title Add more irradiance metrics to pvlib.irradiance Add clearsky index function to pvlib.irradiance Jan 30, 2019
@cwhanse
Copy link
Member

cwhanse commented Mar 6, 2019

Closed via #571. If we want to add the variability index, let's open a new issue.

@cwhanse cwhanse closed this as completed Mar 6, 2019
@kandersolar kandersolar modified the milestones: Someday, 0.6.1 May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants