Skip to content

Charge transfer coefficients defined but not use. #5522

Description

@brosaplanella

Issue

In most parameter sets we define "Positive/Negative electrode charge transfer coefficient", which is set to 0.5. This parameter actually is not used anywhere, which is confusing. The actual parameter used in AsymmetricButlerVolmer is "Positive/Negative electrode Butler-Volmer transfer coefficient", but as far as I can tell AsymmetricButlerVolmer is not used in any of the models.

Proposed solution

Short term:

  • Remove the "Positive/Negative electrode charge transfer coefficient" from all parameter sets.

Longer term (needs discussion/separate issue):

  • Make AsymmetricButlerVolmer the default with the (right) charge transfer coefficient defined as 0.5 in the parameter sets (behaviour should be the same as we have now, not sure how performance will be affected).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions