Fixing silly oversight (discovered while creating PR #3041).

rwgk · rwgk · commit 4ab4f36a92e9 · 2021-06-30T07:04:31.000-07:00
diff --git a/include/pybind11/detail/smart_holder_poc.h b/include/pybind11/detail/smart_holder_poc.h
@@ -288,7 +288,6 @@ struct smart_holder {
         if (hld.vptr_is_using_builtin_delete) {
             hld.vptr.reset(unq_ptr.get(), make_guarded_builtin_delete<T>(true));
         } else {
-            make_guarded_custom_deleter<T, D>(false);
             hld.vptr.reset(unq_ptr.get(), make_guarded_custom_deleter<T, D>(true));
         }
         unq_ptr.release();

Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,6 @@ struct smart_holder {`
`288`	`288`	`if (hld.vptr_is_using_builtin_delete) {`
`289`	`289`	`hld.vptr.reset(unq_ptr.get(), make_guarded_builtin_delete<T>(true));`
`290`	`290`	`} else {`
`291`		`- make_guarded_custom_deleter<T, D>(false);`
`292`	`291`	`hld.vptr.reset(unq_ptr.get(), make_guarded_custom_deleter<T, D>(true));`
`293`	`292`	`}`
`294`	`293`	`unq_ptr.release();`