Skip to content

Commit 62acc6b

Browse files
committed
Resolve clang-tidy errors:
``` /__w/pybind11/pybind11/tests/test_cpp_conduit_traveler_bindings.h:39:32: error: parameter 'm' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param,-warnings-as-errors] 10 | py::class_<LonelyTraveler>(m, "LonelyTraveler"); | ^ | std::move( ) /__w/pybind11/pybind11/tests/test_cpp_conduit_traveler_bindings.h:43:52: error: parameter 'm' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param,-warnings-as-errors] 43 | py::class_<VeryLonelyTraveler, LonelyTraveler>(m, "VeryLonelyTraveler"); | ^ | std::move( ) ```
1 parent 22dbfa6 commit 62acc6b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tests/test_cpp_conduit_traveler_bindings.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,11 @@ inline void wrap_traveler(py::module_ m) {
3636
}
3737

3838
inline void wrap_lonely_traveler(py::module_ m) {
39-
py::class_<LonelyTraveler>(m, "LonelyTraveler");
39+
py::class_<LonelyTraveler>(std::move(m), "LonelyTraveler");
4040
}
4141

4242
inline void wrap_very_lonely_traveler(py::module_ m) {
43-
py::class_<VeryLonelyTraveler, LonelyTraveler>(m, "VeryLonelyTraveler");
43+
py::class_<VeryLonelyTraveler, LonelyTraveler>(std::move(m), "VeryLonelyTraveler");
4444
}
4545

4646
} // namespace test_cpp_conduit

0 commit comments

Comments
 (0)