tests: Add test for boost::histogram::func_transform situation. (#5582)

* Add test for boost::histogram::func_transform situation.

* Resolve clang-tidy errors

```
/__w/pybind11/pybind11/tests/test_callbacks.cpp:33:9: error: 'auto rec' can be declared as 'auto *rec' [readability-qualified-auto,-warnings-as-errors]
   33 |         auto rec = c.get_pointer<py::detail::function_record>();
      |         ^~~~
      |         auto *
/__w/pybind11/pybind11/tests/test_callbacks.cpp:41:13: error: 'auto cap' can be declared as 'auto *cap' [readability-qualified-auto,-warnings-as-errors]
   41 |             auto cap = reinterpret_cast<capture *>(&rec->data);
      |             ^~~~
      |             auto *
```

* Replace `apply_custom_transform()` implementation using `make_caster<std::function<raw_t>>`

* Add func_is_stateless_with_exact_type feature in pybind11/functional.h

* tests: use std::function::target

Signed-off-by: Henry Schreiner <[email protected]>

* style: pre-commit fixes

* Resolve clang-tidy error

```
/__w/pybind11/pybind11/tests/test_callbacks.cpp:33:5: error: 'auto cfunc' can be declared as 'auto *cfunc' [readability-qualified-auto,-warnings-as-errors]
   33 |     auto cfunc = func.target<raw_t *>();
      |     ^~~~
      |     auto *
```

---------

Signed-off-by: Henry Schreiner <[email protected]>
Co-authored-by: Henry Schreiner <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: 3 people

tests/test_callbacks.cpp

@@ -14,6 +14,32 @@
 
 #include <thread>
 
+namespace test_callbacks {
+namespace boost_histogram { // See PR #5580
+
+double custom_transform_double(double value) { return value * 3; }
+int custom_transform_int(int value) { return value; }
+
+// Originally derived from
+// https://github.com/scikit-hep/boost-histogram/blob/460ef90905d6a8a9e6dd3beddfe7b4b49b364579/include/bh_python/transform.hpp#L68-L85
+double apply_custom_transform(const py::object &src, double value) {
+    using raw_t = double(double);
+
+    py::detail::make_caster<std::function<raw_t>> func_caster;
+    if (!func_caster.load(src, /*convert*/ false)) {
+        return -100;
+    }
+    auto func = static_cast<std::function<raw_t> &>(func_caster);
+    auto *cfunc = func.target<raw_t *>();
+    if (cfunc == nullptr) {
+        return -200;
+    }
+    return (*cfunc)(value);
+}
+
+} // namespace boost_histogram
+} // namespace test_callbacks
+
 int dummy_function(int i) { return i + 1; }
 
 TEST_SUBMODULE(callbacks, m) {
@@ -272,4 +298,11 @@ TEST_SUBMODULE(callbacks, m) {
     // rec_capsule with nullptr name
     py::capsule rec_capsule2(std::malloc(1), [](void *data) { std::free(data); });
     m.add_object("custom_function2", PyCFunction_New(custom_def, rec_capsule2.ptr()));
+
+    m.def("boost_histogram_custom_transform_double",
+          test_callbacks::boost_histogram::custom_transform_double);
+    m.def("boost_histogram_custom_transform_int",
+          test_callbacks::boost_histogram::custom_transform_int);
+    m.def("boost_histogram_apply_custom_transform",
+          test_callbacks::boost_histogram::apply_custom_transform);
 }

tests/test_callbacks.py

@@ -234,3 +234,15 @@ def test_callback_docstring():
         m.test_tuple_unpacking.__doc__.strip()
         == "test_tuple_unpacking(arg0: Callable) -> object"
     )
+
+
+def test_boost_histogram_apply_custom_transform():
+    ctd = m.boost_histogram_custom_transform_double
+    cti = m.boost_histogram_custom_transform_int
+    apply = m.boost_histogram_apply_custom_transform
+    assert apply(ctd, 5) == 15
+    assert apply(cti, 0) == -200
+    assert apply(None, 0) == -100
+    assert apply(lambda value: value, 9) == -200
+    assert apply({}, 0) == -100
+    assert apply("", 0) == -100