Apply suggestions from review

Author: QuLogic

include/pybind11/detail/class.h

@@ -602,9 +602,9 @@ extern "C" inline int pybind11_getbuffer(PyObject *obj, Py_buffer *view, int fla
         return -1;
     }
     view->obj = obj;
+    view->ndim = 1;  // See discussion on PR #5407.
     view->internal = info;
     view->buf = info->ptr;
-    view->ndim = (int) info->ndim;
     view->itemsize = info->itemsize;
     view->len = view->itemsize;
     for (auto s : info->shape) {
@@ -615,6 +615,7 @@ extern "C" inline int pybind11_getbuffer(PyObject *obj, Py_buffer *view, int fla
         view->format = const_cast<char *>(info->format.c_str());
     }
     if ((flags & PyBUF_ND) == PyBUF_ND) {
+        view->ndim = (int) info->ndim;
         view->shape = info->shape.data();
     }
     if ((flags & PyBUF_STRIDES) == PyBUF_STRIDES) {

tests/test_buffers.py

@@ -247,7 +247,7 @@ def test_to_pybuffer():
     info = m.get_py_buffer(mat, m.PyBUF_SIMPLE)
     assert info.itemsize == ctypes.sizeof(ctypes.c_float)
     assert info.len == mat.rows() * mat.cols() * info.itemsize
-    assert info.ndim == 2
+    assert info.ndim == 1  # See discussion on PR #5407.
     assert info.shape is None
     assert info.strides is None
     assert info.suboffsets is None