Skip to content

CMake deprecation warning #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mlund opened this issue Nov 3, 2023 · 3 comments
Closed

CMake deprecation warning #64

mlund opened this issue Nov 3, 2023 · 3 comments

Comments

@mlund
Copy link
Contributor

mlund commented Nov 3, 2023

On newer versions of cmake I get this warning:

CMake Deprecation Warning at CMakeLists.txt:9 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.
@ebenali
Copy link

ebenali commented Mar 5, 2024

probably just copy the header into your tree under 3rdparty/ or whatever

@mlund
Copy link
Contributor Author

mlund commented Mar 5, 2024

probably just copy the header into your tree under 3rdparty/ or whatever

I can certainly do that, but the warning suggests that the current CMakeLists.txt will become outdated. An alternative solution would be to increase the minimum CMake version to 3.5, released in 2016.

mlund added a commit to mlund/pybind11_json that referenced this issue Mar 5, 2024
This fixes the deprecation warning as reported in pybind#64
@martinRenou
Copy link
Collaborator

Fixed by #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants