Skip to content

Commit 4a08067

Browse files
isurufwjakob
authored andcommitted
Avoid opening the file twice
1 parent 187e874 commit 4a08067

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

setup.py

+9-9
Original file line numberDiff line numberDiff line change
@@ -40,18 +40,18 @@ def has_flag(compiler, flagname):
4040
"""
4141
import tempfile
4242
import os
43-
with tempfile.NamedTemporaryFile('w', suffix='.cpp') as f:
43+
with tempfile.NamedTemporaryFile('w', suffix='.cpp', delete=False) as f:
4444
f.write('int main (int argc, char **argv) { return 0; }')
4545
fname = f.name
46+
try:
47+
compiler.compile([fname], extra_postargs=[flagname])
48+
except setuptools.distutils.errors.CompileError:
49+
return False
50+
finally:
4651
try:
47-
compiler.compile([fname], extra_postargs=[flagname])
48-
except setuptools.distutils.errors.CompileError:
49-
return False
50-
finally:
51-
try:
52-
os.remove(fname)
53-
except OSError:
54-
pass
52+
os.remove(fname)
53+
except OSError:
54+
pass
5555
return True
5656

5757

0 commit comments

Comments
 (0)