Skip to content

Commit 98596dd

Browse files
authored
Disable pyright config? (#9570)
* Remove superfluous lines from pyright config * Disable pyright config? I'd propose disabling pyright in the `pyproject.toml` file for now, since including it means that all errors show up in devs' vscode, which then makes it more difficult to work with the actual errors. It overrides local VS Code settings, so I don't think is possible to disable...
1 parent 5c64182 commit 98596dd

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

pyproject.toml

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -214,13 +214,16 @@ warn_return_any = true
214214

215215
module = ["xarray.namedarray.*", "xarray.tests.test_namedarray"]
216216

217-
[tool.pyright]
218-
defineConstant = {DEBUG = true}
219-
220-
# Enabling this means that developers who have disabled the warning locally —
221-
# because not all dependencies are installable — are overridden
222-
# reportMissingImports = true
223-
reportMissingTypeStubs = false
217+
# We disable pyright here for now, since including it means that all errors show
218+
# up in devs' VS Code, which then makes it more difficult to work with actual
219+
# errors. It overrides local VS Code settings so isn't escapable.
220+
221+
# [tool.pyright]
222+
# defineConstant = {DEBUG = true}
223+
# # Enabling this means that developers who have disabled the warning locally —
224+
# # because not all dependencies are installable — are overridden
225+
# # reportMissingImports = true
226+
# reportMissingTypeStubs = false
224227

225228
[tool.ruff]
226229
extend-exclude = [

0 commit comments

Comments
 (0)