Discard useless !s conversion in f-string (#9752)

DimitriPapadopoulos · web-flow · commit a78f45a9c33b · 2024-11-08T07:36:03.000-07:00
diff --git a/xarray/core/utils.py b/xarray/core/utils.py
@@ -1008,7 +1008,7 @@ def parse_ordered_dims(
 def _check_dims(dim: Set[Hashable], all_dims: Set[Hashable]) -> None:
     wrong_dims = (dim - all_dims) - {...}
     if wrong_dims:
-        wrong_dims_str = ", ".join(f"'{d!s}'" for d in wrong_dims)
+        wrong_dims_str = ", ".join(f"'{d}'" for d in wrong_dims)
         raise ValueError(
             f"Dimension(s) {wrong_dims_str} do not exist. Expected one or more of {all_dims}"
         )

Original file line number	Diff line number	Diff line change
`@@ -1008,7 +1008,7 @@ def parse_ordered_dims(`
`1008`	`1008`	`def _check_dims(dim: Set[Hashable], all_dims: Set[Hashable]) -> None:`
`1009`	`1009`	`wrong_dims = (dim - all_dims) - {...}`
`1010`	`1010`	`if wrong_dims:`
`1011`		`- wrong_dims_str = ", ".join(f"'{d!s}'" for d in wrong_dims)`
	`1011`	`+ wrong_dims_str = ", ".join(f"'{d}'" for d in wrong_dims)`
`1012`	`1012`	`raise ValueError(`
`1013`	`1013`	`f"Dimension(s) {wrong_dims_str} do not exist. Expected one or more of {all_dims}"`
`1014`	`1014`	`)`