Skip to content

Tracking internal uses of concat that don't allow setting all the kwargs #10095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jsignell opened this issue Mar 4, 2025 · 0 comments
Open

Tracking internal uses of concat that don't allow setting all the kwargs #10095

jsignell opened this issue Mar 4, 2025 · 0 comments
Labels
topic-combine combine/concat/merge topic-internals

Comments

@jsignell
Copy link
Contributor

jsignell commented Mar 4, 2025

What is your issue?

While working on #8778 I encountered some places where concat is used internally but the kwargs are not individually settable: stack and groupby.

#10062 hardcodes them to the old defaults: data_vars="all", coords="different", compat="equals", join="outer"

@dcherian mentioned (https://github.com/pydata/xarray/pull/10062/files#r1978040669) that we might want stricter behavior.
@jsignell jsignell added the needs triage Issue that has not been reviewed by xarray team member label Mar 4, 2025
@jsignell jsignell mentioned this issue Mar 4, 2025
Open
4 tasks
@TomNicholas TomNicholas added topic-internals topic-combine combine/concat/merge and removed needs triage Issue that has not been reviewed by xarray team member labels Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-combine combine/concat/merge topic-internals
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsignell @TomNicholas