Skip to content

Remove do-operator from pymc-experimental #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
twiecki opened this issue Aug 25, 2023 · 6 comments · Fixed by #240
Closed

Remove do-operator from pymc-experimental #237

twiecki opened this issue Aug 25, 2023 · 6 comments · Fixed by #240
Labels
help wanted Extra attention is needed

Comments

@twiecki
Copy link
Member

twiecki commented Aug 25, 2023

Description

@ricardoV94 said that things have stabilized enough to where we can port it to pymc proper. Code can be found here: https://github.com/pymc-devs/pymc-experimental/blob/main/pymc_experimental/model_transform/conditioning.py

@twiecki twiecki added feature request help wanted Extra attention is needed labels Aug 25, 2023
@ricardoV94
Copy link
Member

This involves moving everything in utils.model_fgraph and model_transform. It probably makes sense to make a submodule model in pymc instead of the single pymc.model.py file that currently exists

@juanitorduz
Copy link

juanitorduz commented Aug 28, 2023

I want to support this initiative. The idea is to create a model submodule and have:

model
|-- model.py (this will imply a lot of paths refactors done automatically)
|--model_transform.py  (from pymc experimental)
|--utils
|----model_fgraph.py (from pymc experimental)

Plus, adding tests?

@twiecki
Copy link
Member Author

twiecki commented Aug 28, 2023

@juanitorduz That's great! @ricardoV94 will know but it looks correct to me. We should probably find better names for the files though.

@ricardoV94
Copy link
Member

ricardoV94 commented Aug 28, 2023

I want to support this initiative. The idea is to create a model submodule and have:

model
|-- model.py (this will imply a lot of paths refactors done automatically)
|--model_transform.py  (from pymc experimental)
|--utils
|----model_fgraph.py (from pymc experimental)

The utils isn't needed, just put model_fgraph.py inside the model module.

Plus, adding tests?

All functionality is already tested here, so you just need to port the tests.

@juanitorduz
Copy link

Ok! I gave it a shot in pymc-devs/pymc#6879 . I hope I did not mess up anything (do not trust me hehe)

@ricardoV94 ricardoV94 transferred this issue from pymc-devs/pymc Sep 5, 2023
@ricardoV94
Copy link
Member

We need to remove it from pymc-experimental now that it's in PyMC

@twiecki twiecki changed the title Move do-operator from pymc-experimental to pymc Remove do-operator from pymc-experimental Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants