-
-
Notifications
You must be signed in to change notification settings - Fork 58
Remove do-operator from pymc-experimental #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This involves moving everything in |
I want to support this initiative. The idea is to create a
Plus, adding tests? |
@juanitorduz That's great! @ricardoV94 will know but it looks correct to me. We should probably find better names for the files though. |
The
All functionality is already tested here, so you just need to port the tests. |
Ok! I gave it a shot in pymc-devs/pymc#6879 . I hope I did not mess up anything (do not trust me hehe) |
We need to remove it from pymc-experimental now that it's in PyMC |
Description
@ricardoV94 said that things have stabilized enough to where we can port it to pymc proper. Code can be found here: https://github.com/pymc-devs/pymc-experimental/blob/main/pymc_experimental/model_transform/conditioning.py
The text was updated successfully, but these errors were encountered: