Skip to content

Commit 6a722da

Browse files
michaelosthegetwiecki
authored andcommitted
XFAIL MLDA tests because it needs refactoring
See #5021
1 parent f73e933 commit 6a722da

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

Diff for: pymc3/tests/test_examples.py

+3
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,9 @@ def build_models(self):
350350

351351
return model, coarse_models
352352

353+
@pytest.mark.skip(
354+
reason="MLDA needs to be refactored to no longer depend on trace continuation. See #5021."
355+
)
353356
def test_run(self):
354357
model, coarse_models = self.build_models()
355358

Diff for: pymc3/tests/test_step.py

+9-5
Original file line numberDiff line numberDiff line change
@@ -579,11 +579,12 @@ def test_step_continuous(self):
579579
HamiltonianMC(scaling=C, is_cov=True, blocked=False),
580580
]
581581
),
582-
MLDA(
583-
coarse_models=[model_coarse],
584-
base_S=C,
585-
base_proposal_dist=MultivariateNormalProposal,
586-
),
582+
# NOTE: The MLDA uses the trace continuation which was removed.
583+
# MLDA(
584+
# coarse_models=[model_coarse],
585+
# base_S=C,
586+
# base_proposal_dist=MultivariateNormalProposal,
587+
# ),
587588
)
588589
for step in steps:
589590
idata = sample(
@@ -1038,6 +1039,9 @@ def test_sampler_stats(self):
10381039
assert (trace.model_logp == model_logp_).all()
10391040

10401041

1042+
@pytest.mark.skip(
1043+
reason="MLDA needs to be refactored to no longer depend on trace continuation. See #5021."
1044+
)
10411045
class TestMLDA:
10421046
steppers = [MLDA]
10431047

0 commit comments

Comments
 (0)