Modify HyperGeom.random; Random test still failing. match_with_scipy test passing

Author: Harivallabha

pymc3/distributions/discrete.py

@@ -881,8 +881,17 @@ def random(self, point=None, size=None):
         -------
         array
         """
+
         N, k, n = draw_values([self.N, self.k, self.n], point=point, size=size)
-        return generate_samples(np.random.hypergeometric, N, k, n, dist_shape=self.shape, size=size)
+        return generate_samples(self._random, N, k, n, dist_shape=self.shape, size=size)
+
+    def _random(self, M, n, N, size=None):
+        r"""Wrapper around scipy stat's hypergeom.rvs"""
+        try:
+            samples = stats.hypergeom.rvs(M=M, n=n, N=N, size=size)
+            return samples
+        except ValueError:
+            raise ValueError("Domain error in arguments")
 
     def logp(self, value):
         r"""

pymc3/tests/test_distributions_random.py

@@ -109,6 +109,7 @@ def pymc3_random_discrete(
                 p = 1.0
             else:
                 _, p = st.chisquare(k[:, 0], k[:, 1])
+                print(p)
             f -= 1
         assert p > alpha, str(pt)
 
@@ -752,7 +753,7 @@ def ref_rand(size, N, k, n):
             pm.HyperGeometric,
             {"N": Nat, "k": Nat, "n": Nat},
             size=500,
-            fails=100,
+            fails=50,
             ref_rand=ref_rand,
         )