Skip to content

Commit 8358a97

Browse files
committed
Add more informative comment
1 parent 9c5aa05 commit 8358a97

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

pymc3/tests/test_distributions.py

+8-2
Original file line numberDiff line numberDiff line change
@@ -1177,12 +1177,15 @@ def test_fun(value, mu, sigma):
11771177

11781178
self.pymc3_matches_scipy(Gamma, Rplus, {"mu": Rplusbig, "sigma": Rplusbig}, test_fun)
11791179

1180+
# pymc-devs/Theano-PyMC#224: skip_paramdomain_outside_edge_test has to be set
1181+
# True to avoid triggering a C-level assertion in the Theano GammaQ function
1182+
# in gamma.c file. Can be set back to False (defalut) once that issue is solved
11801183
self.check_logcdf(
11811184
Gamma,
11821185
Rplus,
11831186
{"alpha": Rplusbig, "beta": Rplusbig},
11841187
lambda value, alpha, beta: sp.gamma.logcdf(value, alpha, scale=1.0 / beta),
1185-
skip_paramdomain_outside_edge_test=True, # TODO: When True, Python crashes
1188+
skip_paramdomain_outside_edge_test=True,
11861189
)
11871190

11881191
@pytest.mark.xfail(
@@ -1196,12 +1199,15 @@ def test_inverse_gamma(self):
11961199
{"alpha": Rplus, "beta": Rplus},
11971200
lambda value, alpha, beta: sp.invgamma.logpdf(value, alpha, scale=beta),
11981201
)
1202+
# pymc-devs/Theano-PyMC#224: skip_paramdomain_outside_edge_test has to be set
1203+
# True to avoid triggering a C-level assertion in the Theano GammaQ function
1204+
# in gamma.c file. Can be set back to False (defalut) once that issue is solved
11991205
self.check_logcdf(
12001206
InverseGamma,
12011207
Rplus,
12021208
{"alpha": Rplus, "beta": Rplus},
12031209
lambda value, alpha, beta: sp.invgamma.logcdf(value, alpha, scale=beta),
1204-
skip_paramdomain_outside_edge_test=True, # TODO: When True, Python crashes
1210+
skip_paramdomain_outside_edge_test=True,
12051211
)
12061212

12071213
@pytest.mark.xfail(

0 commit comments

Comments
 (0)