Skip to content

PyMC3 Plotting docs link to wrong ArviZ Link #4319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
canyon289 opened this issue Dec 9, 2020 · 5 comments
Closed

PyMC3 Plotting docs link to wrong ArviZ Link #4319

canyon289 opened this issue Dec 9, 2020 · 5 comments

Comments

@canyon289
Copy link
Member

canyon289 commented Dec 9, 2020

Description of your problem

Links on this page are broken. They should be changed to link to the correct arviz plotting documentation

https://docs.pymc.io/api/plots.html

@CloudChaoszero
Copy link
Contributor

Hey there, @canyon289. I think I found a fix. 🤞 Submitted a PR now

@CloudChaoszero
Copy link
Contributor

CloudChaoszero commented Dec 15, 2020

@canyon289 Hey there! Hope you are doing well.

From this PR #4333 ,
It appears that the original .rst file should work for the re-directed links. Moreover, if i made a change to the conf.py, that was not correct.

Maybe the docs should be re-built?

Here is an example of my local changes using make html && make serve

  • See the re-direct link, at the bottom left of the screenshot

Local sphinx changes for arviz hyperlink redirect

@canyon289
Copy link
Member Author

@CloudChaoszero Looks like the other contributors have been helping out. I just wanted to stop by and say thanks for taking this on and following through. Its very much appreciated :)

@MarcoGorelli
Copy link
Contributor

Closing as these work fine with the latest build of the docs

@OriolAbril
Copy link
Member

Sorry I'm late to the party and thanks for being on top of that everyone! 😄

I refactored the stats and plots links a while back (#3927) to use intersphinx instead of using html links precisely to try to avoid having to edit the source if ArviZ docs were changed. When using intersphinx, as long as the homepage address is not modified, rebuilding the docs should always regenerate the links and fix any that have ended up outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants