Skip to content

check what is run with make doctest and make test #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
drbenvincent opened this issue Dec 12, 2023 · 2 comments
Closed

check what is run with make doctest and make test #278

drbenvincent opened this issue Dec 12, 2023 · 2 comments
Labels
devops DevOps related good first issue Good for newcomers

Comments

@drbenvincent
Copy link
Collaborator

  • Running make doctest locally took over 5 mins and there were 84 passing tests.
  • Running make test locally took just over 2 mins with 62 passing tests.

Something about make doctest doesn't sound right. I don't think we have anywhere close to 84 docstrings that need doctest. Maybe it's additionally running the regular tests on top of the doctests? Either way, it would be great to get to the bottom of this to save time and local and remote compute time.

Tagging @jpreszler just in case you're interested in taking a look into this.

@jpreszler
Copy link
Contributor

Here's a PR for an improvement. #280

The tests were getting run twice, but doctests still take a while. This is mainly because some of the tests require doing enough MCMC sampling for numeric stability in the examples. There's likely ways to save time here also, but it's not a simple as just reducing the pytest test collection.

@drbenvincent
Copy link
Collaborator Author

Closed by #280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops DevOps related good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants