Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tests using mock_fetch with selenium-based tests #210

Open
ryanking13 opened this issue Feb 19, 2025 · 0 comments
Open

Replace tests using mock_fetch with selenium-based tests #210

ryanking13 opened this issue Feb 19, 2025 · 0 comments

Comments

@ryanking13
Copy link
Member

ryanking13 commented Feb 19, 2025

Tests with mock_fetch (and mock_importlib ) is quite fragile and hard to maintain. I think we should replace those with selenium-based tests as much as possible.

When micropip was in pyodide/pyodide, we avoided using selenium tests because selenium-based tests would increase the overall test time. But now, micropip lives in a separate repository. So, I think taking a few more minutes to run the test is not a big concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant