Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about how to build, test, contribute to readme #215

Open
hoodmane opened this issue Feb 22, 2025 · 4 comments
Open

Add information about how to build, test, contribute to readme #215

hoodmane opened this issue Feb 22, 2025 · 4 comments

Comments

@hoodmane
Copy link
Member

Readme has no info currently about building or testing micropip. It isn't completely obvious how to run the tests.

@hoodmane
Copy link
Member Author

I'm getting the following problem:

$ pip install -e micropip[tests]
$ pytest tests/ --rt node
ImportError while loading conftest '/home/rchatham/Documents/programming/micropip/tests/conftest.py'.
tests/conftest.py:17: in <module>
    from micropip._vendored.packaging.src.packaging.utils import parse_wheel_filename
micropip/__init__.py:1: in <module>
    from .package_manager import PackageManager
micropip/package_manager.py:11: in <module>
    from . import _mock_package, package_index
micropip/package_index.py:13: in <module>
    from ._utils import is_package_compatible, parse_version
micropip/_utils.py:8: in <module>
    from ._vendored.packaging.src.packaging.requirements import (
E   ModuleNotFoundError: No module named 'micropip._vendored.packaging.src'

@ryanking13
Copy link
Member

Yeah, I think we need to mention about

  • cloning with submodules
  • setting up pytest-pyodide to run test

@hoodmane
Copy link
Member Author

Right, there should maybe be a script to setup the tests since we have to fetch pyodide and unpack it.

@hoodmane
Copy link
Member Author

It's very annoying that the CI uses:
pyodide/pyodide-actions/download-pyodide@012fa537869d343726d01863a34b773fc4d96a14
so if I want to figure out what this does I have to go to another different repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants