-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Expand file tree
/
Copy pathtest_views.py
More file actions
563 lines (444 loc) · 20.7 KB
/
test_views.py
File metadata and controls
563 lines (444 loc) · 20.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import pretend
import pytest
from natsort import natsorted
from pyramid.httpexceptions import HTTPMovedPermanently, HTTPNotFound
from warehouse.packaging import views
from ...common.db.accounts import UserFactory
from ...common.db.classifiers import ClassifierFactory
from ...common.db.packaging import (
DescriptionFactory,
FileFactory,
ProjectFactory,
ReleaseFactory,
RoleFactory,
)
class TestProjectDetail:
def test_normalizing_redirects(self, db_request):
project = ProjectFactory.create()
name = project.name.lower()
if name == project.name:
name = project.name.upper()
db_request.matchdict = {"name": name}
db_request.current_route_path = pretend.call_recorder(
lambda name: "/project/the-redirect/"
)
resp = views.project_detail(project, db_request)
assert isinstance(resp, HTTPMovedPermanently)
assert resp.headers["Location"] == "/project/the-redirect/"
assert db_request.current_route_path.calls == [pretend.call(name=project.name)]
def test_missing_release(self, db_request):
project = ProjectFactory.create()
with pytest.raises(HTTPNotFound):
views.project_detail(project, db_request)
def test_calls_release_detail(self, monkeypatch, db_request):
project = ProjectFactory.create()
ReleaseFactory.create(project=project, version="1.0")
ReleaseFactory.create(project=project, version="2.0")
release = ReleaseFactory.create(project=project, version="3.0")
response = pretend.stub()
release_detail = pretend.call_recorder(lambda ctx, request: response)
monkeypatch.setattr(views, "release_detail", release_detail)
resp = views.project_detail(project, db_request)
assert resp is response
assert release_detail.calls == [pretend.call(release, db_request)]
def test_with_prereleases(self, monkeypatch, db_request):
project = ProjectFactory.create()
ReleaseFactory.create(project=project, version="1.0")
ReleaseFactory.create(project=project, version="2.0")
ReleaseFactory.create(project=project, version="4.0.dev0")
release = ReleaseFactory.create(project=project, version="3.0")
response = pretend.stub()
release_detail = pretend.call_recorder(lambda ctx, request: response)
monkeypatch.setattr(views, "release_detail", release_detail)
resp = views.project_detail(project, db_request)
assert resp is response
assert release_detail.calls == [pretend.call(release, db_request)]
def test_only_prereleases(self, monkeypatch, db_request):
project = ProjectFactory.create()
ReleaseFactory.create(project=project, version="1.0.dev0")
ReleaseFactory.create(project=project, version="2.0.dev0")
release = ReleaseFactory.create(project=project, version="3.0.dev0")
response = pretend.stub()
release_detail = pretend.call_recorder(lambda ctx, request: response)
monkeypatch.setattr(views, "release_detail", release_detail)
resp = views.project_detail(project, db_request)
assert resp is response
assert release_detail.calls == [pretend.call(release, db_request)]
def test_prefers_non_yanked_release(self, monkeypatch, db_request):
project = ProjectFactory.create()
ReleaseFactory.create(project=project, version="2.0", yanked=True)
release = ReleaseFactory.create(project=project, version="1.0")
response = pretend.stub()
release_detail = pretend.call_recorder(lambda ctx, request: response)
monkeypatch.setattr(views, "release_detail", release_detail)
resp = views.project_detail(project, db_request)
assert resp is response
assert release_detail.calls == [pretend.call(release, db_request)]
def test_only_yanked_release(self, monkeypatch, db_request):
project = ProjectFactory.create()
release = ReleaseFactory.create(project=project, version="1.0", yanked=True)
response = pretend.stub()
release_detail = pretend.call_recorder(lambda ctx, request: response)
monkeypatch.setattr(views, "release_detail", release_detail)
resp = views.project_detail(project, db_request)
assert resp is response
assert release_detail.calls == [pretend.call(release, db_request)]
def test_with_staged(self, monkeypatch, db_request):
project = ProjectFactory.create()
release = ReleaseFactory.create(project=project, version="1.0")
ReleaseFactory.create(project=project, version="1.1", published=False)
response = pretend.stub()
release_detail = pretend.call_recorder(lambda ctx, request: response)
monkeypatch.setattr(views, "release_detail", release_detail)
resp = views.project_detail(project, db_request)
assert resp is response
assert release_detail.calls == [pretend.call(release, db_request)]
class TestReleaseDetail:
def test_normalizing_name_redirects(self, db_request):
project = ProjectFactory.create()
release = ReleaseFactory.create(project=project, version="3.0")
name = release.project.name.lower()
if name == release.project.name:
name = release.project.name.upper()
db_request.matchdict = {"name": name}
db_request.current_route_path = pretend.call_recorder(
lambda name: "/project/the-redirect/3.0/"
)
resp = views.release_detail(release, db_request)
assert isinstance(resp, HTTPMovedPermanently)
assert resp.headers["Location"] == "/project/the-redirect/3.0/"
assert db_request.current_route_path.calls == [
pretend.call(name=release.project.name)
]
def test_normalizing_version_redirects(self, db_request):
project = ProjectFactory.create()
release = ReleaseFactory.create(project=project, version="3.0")
db_request.matchdict = {"name": project.name, "version": "3.0.0.0.0"}
db_request.current_route_path = pretend.call_recorder(
lambda **kw: "/project/the-redirect/3.0/"
)
resp = views.release_detail(release, db_request)
assert isinstance(resp, HTTPMovedPermanently)
assert resp.headers["Location"] == "/project/the-redirect/3.0/"
assert db_request.current_route_path.calls == [
pretend.call(name=release.project.name, version=release.version)
]
def test_detail_rendered(self, db_request):
users = [UserFactory.create(), UserFactory.create(), UserFactory.create()]
project = ProjectFactory.create()
releases = [
ReleaseFactory.create(
project=project,
version=v,
description=DescriptionFactory.create(
raw="unrendered description",
html="rendered description",
content_type="text/html",
),
)
for v in ["1.0", "2.0", "3.0", "4.0.dev0"]
] + [
ReleaseFactory.create(
project=project,
version="5.0",
description=DescriptionFactory.create(
raw="plaintext description",
html="",
content_type="text/plain",
),
yanked=True,
yanked_reason="plaintext yanked reason",
)
]
# Add a staged version
staged_release = ReleaseFactory.create(
project=project,
version="5.1",
description=DescriptionFactory.create(
raw="unrendered description",
html="rendered description",
content_type="text/html",
),
published=False,
)
files = [
FileFactory.create(
release=r,
filename=f"{project.name}-{r.version}.tar.gz",
python_version="source",
packagetype="sdist",
)
for r in releases + [staged_release]
]
# Create a role for each user
for user in users:
RoleFactory.create(user=user, project=project)
result = views.release_detail(releases[1], db_request)
assert result == {
"project": project,
"release": releases[1],
"files": [files[1]],
"sdists": [files[1]],
"bdists": [],
"description": "rendered description",
"latest_version": project.latest_version,
# Non published version are not listed here
"all_versions": [
(r.version, r.created, r.is_prerelease, r.yanked, r.yanked_reason)
for r in reversed(releases)
],
"maintainers": sorted(users, key=lambda u: u.username.lower()),
"license": None,
"PEP740AttestationViewer": views.PEP740AttestationViewer,
}
def test_detail_renders_files_natural_sort(self, db_request):
"""Tests that when a release has multiple versions of Python,
the sort order is most recent Python version first."""
project = ProjectFactory.create()
release = ReleaseFactory.create(project=project, version="3.0")
files = [
FileFactory.create(
release=release,
filename=f"{project.name}-{release.version}-{py_ver}.whl",
python_version="py2.py3",
packagetype="bdist_wheel",
)
for py_ver in ["cp27", "cp310", "cp39"] # intentionally out of order
]
sorted_files = natsorted(files, reverse=True, key=lambda f: f.filename)
result = views.release_detail(release, db_request)
assert result["files"] == sorted_files
def test_license_from_classifier(self, db_request):
"""A license label is added when a license classifier exists."""
other_classifier = ClassifierFactory.create(
classifier="Some :: Random :: Classifier"
)
classifier = ClassifierFactory.create(
classifier="License :: OSI Approved :: BSD License"
)
release = ReleaseFactory.create(
_classifiers=[other_classifier, classifier],
license="Will be added at the end",
)
result = views.release_detail(release, db_request)
assert result["license"] == "BSD License (Will be added at the end)"
def test_license_with_no_classifier(self, db_request):
"""With no classifier, a license is used from metadata."""
release = ReleaseFactory.create(license="MIT License")
result = views.release_detail(release, db_request)
assert result["license"] == "MIT License"
def test_multiline_license(self, db_request):
"""When license metadata is longer than one line, the first is used."""
release = ReleaseFactory.create(license="Multiline License\nhow terrible")
result = views.release_detail(release, db_request)
assert result["license"] == "Multiline License"
def test_no_license(self, db_request):
"""With no license classifier or metadata, no license is in context."""
release = ReleaseFactory.create()
result = views.release_detail(release, db_request)
assert result["license"] is None
def test_multiple_licenses_from_classifiers(self, db_request):
"""A license label is added when multiple license classifiers exist."""
license_1 = ClassifierFactory.create(
classifier="License :: OSI Approved :: BSD License"
)
license_2 = ClassifierFactory.create(
classifier="License :: OSI Approved :: MIT License"
)
release = ReleaseFactory.create(_classifiers=[license_1, license_2])
result = views.release_detail(release, db_request)
assert result["license"] == "BSD License, MIT License"
def test_long_singleline_license(self, db_request):
"""When license metadata contains no newlines, it gets truncated"""
release = ReleaseFactory.create(
license="Multiline License is very long, so long that it is far longer than"
" 100 characters, it's really so long, how terrible"
)
result = views.release_detail(release, db_request)
assert result["license"] == (
"Multiline License is very long, so long that it is far longer than 100 "
"characters, it's really so lo..."
)
def test_created_with_published(self, db_request):
release = ReleaseFactory.create()
assert release.published is True
class TestPEP740AttestationViewer:
@pytest.fixture
def gitlab_attestation(self, gitlab_provenance):
return gitlab_provenance.attestation_bundles[0].attestations[0]
@pytest.fixture
def github_attestation(self, github_provenance):
return github_provenance.attestation_bundles[0].attestations[0]
def test_github_pep740(self, github_attestation):
github_publisher = pretend.stub(
kind="GitHub",
workflow=".github/workflows/release.yml",
)
viewer = views.PEP740AttestationViewer(
publisher=github_publisher,
attestation=github_attestation,
)
assert viewer.statement_type == "https://in-toto.io/Statement/v1"
assert viewer.predicate_type == "https://docs.pypi.org/attestations/publish/v1"
assert viewer.subject_name == "sampleproject-4.0.0.tar.gz"
assert (
viewer.subject_digest
== "0ace7980f82c5815ede4cd7bf9f6693684cec2ae47b9b7ade9add533b8627c6b"
)
assert viewer.transparency_entry["integratedTime"] == "1730932627"
assert viewer.repository_url == "https://github.com/pypa/sampleproject"
assert viewer.workflow_filename == ".github/workflows/release.yml"
assert viewer.workflow_url == (
"https://github.com/pypa/sampleproject/blob/"
"621e4974ca25ce531773def586ba3ed8e736b3fc/"
".github/workflows/release.yml"
)
assert viewer.build_digest == "621e4974ca25ce531773def586ba3ed8e736b3fc"
assert viewer.issuer == "https://token.actions.githubusercontent.com"
assert viewer.environment == "github-hosted"
assert viewer.source == "https://github.com/pypa/sampleproject"
assert viewer.source_digest == "621e4974ca25ce531773def586ba3ed8e736b3fc"
assert viewer.source_reference == "refs/heads/main"
assert viewer.owner == "https://github.com/pypa"
assert viewer.trigger == "push"
assert viewer.access == "public"
assert viewer.permalink_with_digest == (
"https://github.com/pypa/sampleproject/tree/"
"621e4974ca25ce531773def586ba3ed8e736b3fc"
)
assert (
viewer.permalink_with_reference
== "https://github.com/pypa/sampleproject/tree/refs/heads/main"
)
def test_gitlab_pep740(self, gitlab_attestation):
gitlab_publisher = pretend.stub(
kind="GitLab",
workflow_filepath=".gitlab-ci.yml",
)
viewer = views.PEP740AttestationViewer(
publisher=gitlab_publisher,
attestation=gitlab_attestation,
)
assert viewer.statement_type == "https://in-toto.io/Statement/v1"
assert viewer.predicate_type == "https://docs.pypi.org/attestations/publish/v1"
assert viewer.subject_name == "pep740_sampleproject-1.0.0.tar.gz"
assert (
viewer.subject_digest
== "6cdd4a1a0a49aeef47265e7bf8ec1667257b397d34d731dc7b7af349deca1cd8"
)
assert viewer.transparency_entry["integratedTime"] == "1732724143"
assert (
viewer.repository_url == "https://gitlab.com/pep740-example/sampleproject"
)
assert viewer.workflow_filename == ".gitlab-ci.yml"
assert viewer.workflow_url == (
"https://gitlab.com/pep740-example/sampleproject/blob/"
"0b706bbf1b50e7266b33762568566d6ec0f76d69//.gitlab-ci.yml"
)
assert viewer.build_digest == "0b706bbf1b50e7266b33762568566d6ec0f76d69"
assert viewer.issuer == "https://gitlab.com"
assert viewer.environment == "gitlab-hosted"
assert viewer.source == "https://gitlab.com/pep740-example/sampleproject"
assert viewer.source_digest == "0b706bbf1b50e7266b33762568566d6ec0f76d69"
assert viewer.source_reference == "refs/heads/main"
assert viewer.owner == "https://gitlab.com/pep740-example"
assert viewer.trigger == "push"
assert viewer.access == "private"
assert viewer.permalink_with_digest == (
"https://gitlab.com/pep740-example/sampleproject/-/tree/"
"0b706bbf1b50e7266b33762568566d6ec0f76d69"
)
assert (
viewer.permalink_with_reference
== "https://gitlab.com/pep740-example/sampleproject/-/tree/main"
)
def test_unknown_publisher(self, github_attestation):
viewer = views.PEP740AttestationViewer(
publisher=pretend.stub(
kind="Unknown",
),
attestation=pretend.stub(certificate_claims={}),
)
assert viewer.workflow_filename == ""
assert (
viewer._format_url("https://example.com", "refs/heads/main")
== "https://example.com/refs/heads/main"
)
class TestReportMalwareButton:
def test_report_malware_button(self):
project = pretend.stub()
assert views.includes_submit_malware_observation(project, pretend.stub()) == {
"project": project
}
class TestProjectSubmitMalwareObservation:
def test_get_render_form(self, pyramid_request):
project = pretend.stub()
form_obj = pretend.stub()
form_class = pretend.call_recorder(lambda d, **kw: form_obj)
result = views.submit_malware_observation(
project, pyramid_request, _form_class=form_class
)
assert result == {"project": project, "form": form_obj}
assert form_class.calls == [pretend.call(pyramid_request.POST)]
def test_post_invalid_form(self, pyramid_request):
project = pretend.stub()
form_obj = pretend.stub()
form_obj.validate = pretend.call_recorder(lambda: False)
form_class = pretend.call_recorder(lambda d, **kw: form_obj)
pyramid_request.method = "POST"
result = views.submit_malware_observation(
project, pyramid_request, _form_class=form_class
)
assert result == {"project": project, "form": form_obj}
assert form_obj.validate.calls == [pretend.call()]
def test_post_valid_form(self, db_request):
user = UserFactory.create()
project = ProjectFactory.create()
form_obj = pretend.stub()
form_obj.inspector_link = pretend.stub(
data=f"https://inspector.pypi.io/project/{project.name}/"
)
form_obj.summary = pretend.stub(data="Bad stuff in here")
form_obj.validate = pretend.call_recorder(lambda: True)
form_class = pretend.call_recorder(lambda d, **kw: form_obj)
db_request.method = "POST"
db_request.route_path = pretend.call_recorder(
lambda *a, **kw: f"/project/{project.name}/"
)
db_request.session = pretend.stub(
flash=pretend.call_recorder(lambda *a, **kw: None)
)
db_request.user = user
result = views.submit_malware_observation(
project, db_request, _form_class=form_class
)
assert isinstance(result, HTTPMovedPermanently)
assert result.headers["Location"] == f"/project/{project.name}/"
assert form_obj.validate.calls == [pretend.call()]
assert db_request.session.flash.calls == [
pretend.call(
"Your report has been recorded. Thank you for your help.",
queue="success",
)
]
assert db_request.route_path.calls == [
pretend.call("packaging.project", name=project.name)
]
assert len(project.observations) == 1
class TestEditProjectButton:
def test_edit_project_button_returns_project(self):
project = pretend.stub()
assert views.edit_project_button(project, pretend.stub()) == {
"project": project
}